From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH 2/3] fs/superblock: Avoid locking counting inodes and dentries before reclaiming them Date: Thu, 22 May 2014 11:59:34 -0400 Message-ID: <537E1EE6.8080102@redhat.com> References: <1400749779-24879-1-git-send-email-mgorman@suse.de> <1400749779-24879-3-git-send-email-mgorman@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Johannes Weiner , Hugh Dickins , Tim Chen , Dave Chinner , Yuanhan Liu , Bob Liu , Jan Kara , Linux Kernel , Linux-MM , Linux-FSDevel To: Mel Gorman , Andrew Morton Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24808 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809AbaEVP7q (ORCPT ); Thu, 22 May 2014 11:59:46 -0400 In-Reply-To: <1400749779-24879-3-git-send-email-mgorman@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/22/2014 05:09 AM, Mel Gorman wrote: > From: Tim Chen > > We remove the call to grab_super_passive in call to super_cache_count. > This becomes a scalability bottleneck as multiple threads are trying to do > memory reclamation, e.g. when we are doing large amount of file read and > page cache is under pressure. The cached objects quickly got reclaimed > down to 0 and we are aborting the cache_scan() reclaim. But counting > creates a log jam acquiring the sb_lock. > Signed-off-by: Tim Chen > Signed-off-by: Mel Gorman Acked-by: Rik van Riel -- All rights reversed