From: Jens Axboe <axboe@kernel.dk>
To: Stefan Roesch <shr@fb.com>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@fb.com
Cc: viro@zeniv.linux.org.uk
Subject: Re: [PATCH v3 0/2] io-uring: Make statx api stable
Date: Fri, 18 Feb 2022 09:15:13 -0700 [thread overview]
Message-ID: <539953d3-bc83-0b6d-24b3-214f6cdaeb65@kernel.dk> (raw)
In-Reply-To: <20220215180328.2320199-1-shr@fb.com>
On 2/15/22 11:03 AM, Stefan Roesch wrote:
> One of the key architectual tenets of io-uring is to keep the
> parameters for io-uring stable. After the call has been submitted,
> its value can be changed. Unfortunaltely this is not the case for
> the current statx implementation.
>
> Patches:
> Patch 1: fs: replace const char* parameter in vfs_statx and do_statx with
> struct filename
> Create filename object outside of do_statx and vfs_statx, so io-uring
> can create the filename object during the prepare phase
>
> Patch 2: io-uring: Copy path name during prepare stage for statx
> Create and store filename object during prepare phase
>
>
> There is also a patch for the liburing libray to add a new test case. This
> patch makes sure that the api is stable.
> "liburing: add test for stable statx api"
>
> The patch has been tested with the liburing test suite and fstests.
Al, are you happy with this version?
--
Jens Axboe
next prev parent reply other threads:[~2022-02-18 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 18:03 [PATCH v3 0/2] io-uring: Make statx api stable Stefan Roesch
2022-02-15 18:03 ` [PATCH v3 1/2] fs: replace const char* parameter in vfs_statx and do_statx with struct filename Stefan Roesch
2022-02-15 18:03 ` [PATCH v3 2/2] io-uring: Copy path name during prepare stage for statx Stefan Roesch
2022-02-18 16:15 ` Jens Axboe [this message]
2022-02-22 18:45 ` [PATCH v3 0/2] io-uring: Make statx api stable Jens Axboe
2022-02-22 18:45 ` Jens Axboe
[not found] ` <CGME20220224124715eucas1p2a7d1b7f2a5131ef1dd5b8280c1d3749b@eucas1p2.samsung.com>
2022-02-24 12:47 ` Marek Szyprowski
2022-02-24 14:09 ` Jens Axboe
2022-02-25 1:27 ` Qian Cai
2022-02-26 1:22 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539953d3-bc83-0b6d-24b3-214f6cdaeb65@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).