From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH v3] direct-io: fix uninitialized warning in do_direct_IO() Date: Tue, 22 Jul 2014 12:03:23 +0300 Message-ID: <53CE28DB.8080109@gmail.com> References: <1404452632-10912-1-git-send-email-pramod.gurav.etc@gmail.com> <20140713115022.GA6054@infradead.org> <53C6B199.2070606@gmail.com> <20140716175803.GA3631@infradead.org> <1405536124.4357.17.camel@x41> <53C79949.7010201@gmail.com> <53C7AF58.5030807@gmail.com> <1405596599.5735.11.camel@x41> <53CB8730.40607@plexistor.com> <20140721113653.GC2628@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Paul Bolle , Al Viro , Borislav Petkov , Sam Ravnborg , pramod.gurav.etc@gmail.com, Jason Cooper , Markus Mayer , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig , Boaz Harrosh Return-path: In-Reply-To: <20140721113653.GC2628@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 07/21/2014 02:36 PM, Christoph Hellwig wrote: > Looks good to me, > > Reviewed-by: Christoph Hellwig > > While it looks obvious, did you make sure it passes xfstests, which > has a lot of direct I/O tests? > Thank you Christoph. OK So finally I did last night. I ran ext4. Just that I'm not used to run ext4 or any of those stuff so it took me time. I have the usual 2 failures I get also from 3.15. So I'd say its good - tested Thanks Boaz