linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Milosz Tanski <milosz@adfin.com>
To: linux-cachefs@redhat.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David Howells" <dhowells@redhat.com>,
	"NeilBrown" <neilb@suse.de>, "Shantanu Goel" <sgoel01@yahoo.com>
Subject: [PATCH 2/3] FS-Cache: Reduce cookie ref count if submit fails.
Date: Tue, 22 Jul 2014 11:50:58 -0400	[thread overview]
Message-ID: <53CE8862.7020201@adfin.com> (raw)
In-Reply-To: <cover.1406043029.git.milosz@adfin.com>

---
 fs/fscache/object.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/fscache/object.c b/fs/fscache/object.c
index d3b4539..186076b 100644
--- a/fs/fscache/object.c
+++ b/fs/fscache/object.c
@@ -925,6 +925,7 @@ static const struct fscache_state *_fscache_invalidate_object(struct fscache_obj
 {
 	struct fscache_operation *op;
 	struct fscache_cookie *cookie = object->cookie;
+	bool wake_cookie = false;
 
 	_enter("{OBJ%x},%d", object->debug_id, event);
 
@@ -981,7 +982,10 @@ nomem:
 
 submit_op_failed:
 	clear_bit(FSCACHE_OBJECT_IS_LIVE, &object->flags);
+	wake_cookie = __fscache_unuse_cookie(cookie);
 	spin_unlock(&cookie->lock);
+	if (wake_cookie)
+		__fscache_wake_unused_cookie(cookie);
 	kfree(op);
 	_leave(" [EIO]");
 	return transit_to(KILL_OBJECT);
-- 
1.7.9.5

  parent reply	other threads:[~2014-07-22 15:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1406043029.git.milosz@adfin.com>
2014-07-22 15:50 ` [PATCH 1/3] FS-Cache: Timeout for releasepage() Milosz Tanski
2014-07-22 15:50 ` Milosz Tanski [this message]
2014-07-22 15:51 ` [PATCH 3/3] FS-Cache: refcount becomes corrupt under vma preasure Milosz Tanski
2014-07-29 15:32 ` [PATCH 1/3] FS-Cache: Timeout for releasepage() David Howells
2014-07-29 15:35   ` Milosz Tanski
2014-07-29 15:37 ` [PATCH 2/3] FS-Cache: Reduce cookie ref count if submit fails David Howells
2014-08-06 15:21   ` Milosz Tanski
2014-08-11 18:37     ` Milosz Tanski
2014-08-12 12:47   ` David Howells
2014-07-29 16:03 ` [PATCH 3/3] FS-Cache: refcount becomes corrupt under vma preasure David Howells
     [not found] <cover.1407948737.git.milosz@adfin.com>
2014-08-13 16:58 ` [PATCH 2/3] FS-Cache: Reduce cookie ref count if submit fails Milosz Tanski
2014-08-14  4:23   ` NeilBrown
2014-08-27 14:31 ` David Howells
2014-09-04 16:00   ` Milosz Tanski
2014-09-08 15:55     ` Milosz Tanski
2014-09-17 20:23     ` David Howells
2014-09-17 20:24       ` Milosz Tanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CE8862.7020201@adfin.com \
    --to=milosz@adfin.com \
    --cc=dhowells@redhat.com \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=sgoel01@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).