From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops' Date: Fri, 15 Aug 2014 10:19:30 -0600 Message-ID: <53EE3312.2070108@kernel.dk> References: <1408031441-31156-1-git-send-email-ming.lei@canonical.com> <1408031441-31156-5-git-send-email-ming.lei@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Zach Brown , Benjamin LaHaise , Christoph Hellwig , Kent Overstreet , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, Dave Chinner To: Ming Lei , linux-kernel@vger.kernel.org, Andrew Morton , Dave Kleikamp Return-path: In-Reply-To: <1408031441-31156-5-git-send-email-ming.lei@canonical.com> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 08/14/2014 09:50 AM, Ming Lei wrote: > Currently pdu of the flush rq is simlpy copied from another rq, > it isn't enough to initialize pointer field well, so introduce > the callback for driver to handle the case easily. This is the only patch I don't really like. Can't we make do with calling ->init_request() for this instead of having to add another (weird) hook? -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org