From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] block: Fix BUG_ON when pi errors occur Date: Fri, 15 Aug 2014 12:47:37 -0600 Message-ID: <53EE55C9.7090908@kernel.dk> References: <1407930571-26532-1-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kmo@daterainc.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Sagi Grimberg , martin.petersen@oracle.com Return-path: In-Reply-To: <1407930571-26532-1-git-send-email-sagig@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 08/13/2014 05:49 AM, Sagi Grimberg wrote: > When getting a pi error we get to bio_integrity_end_io with > bi_remaining already decremented to 0 where we will eventually > need to call bio_endio with restored original bio completion handler. > Calling bio_endio invokes a BUG_ON(). We should call bio_endio_nodec > instead, like what is done in bio_integrity_verify_fn. Applied, thanks. -- Jens Axboe