From: Gioh Kim <gioh.kim@lge.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org
Cc: "Minchan Kim" <minchan@kernel.org>,
"Joonsoo Kim" <js1304@gmail.com>, 이건호 <gunho.lee@lge.com>
Subject: [PATCHv2 3/3] jbd/jbd2: allocate buffer-cache for superblock inode in non-movable area
Date: Tue, 19 Aug 2014 15:54:09 +0900 [thread overview]
Message-ID: <53F2F491.50208@lge.com> (raw)
In-Reply-To: <53F2F3E6.1030901@lge.com>
A long-lasting buffer-cache can distrub page migration so that
it must be allocated from non-movable area.
The journal_init_inode is creating a buffer-cache for superblock journaling.
The superblock exists until system shutdown so that the buffer-cache
for the superblock would also exist for a long time
and it can distrub page migration.
This patch make the buffer-cache be allocated from non-movable area
not to distrub page migration.
Signed-off-by: Gioh Kim <gioh.kim@lge.com>
---
fs/jbd/journal.c | 2 +-
fs/jbd2/journal.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 06fe11e..a9f8aaf 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -886,7 +886,7 @@ journal_t * journal_init_inode (struct inode *inode)
goto out_err;
}
- bh = __getblk(journal->j_dev, blocknr, journal->j_blocksize);
+ bh = __getblk_gfp(journal->j_dev, blocknr, journal->j_blocksize, 0);
if (!bh) {
printk(KERN_ERR
"%s: Cannot get buffer for journal superblock\n",
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 67b8e30..0461998 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -1237,7 +1237,7 @@ journal_t * jbd2_journal_init_inode (struct inode *inode)
goto out_err;
}
- bh = __getblk(journal->j_dev, blocknr, journal->j_blocksize);
+ bh = __getblk_gfp(journal->j_dev, blocknr, journal->j_blocksize, 0);
if (!bh) {
printk(KERN_ERR
"%s: Cannot get buffer for journal superblock\n",
--
1.7.9.5
prev parent reply other threads:[~2014-08-19 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 6:51 [PATCHv2 0/3] new APIs to allocate buffer-cache with user specific flag Gioh Kim
2014-08-19 6:52 ` [PATCHv2 1/3] fs/buffer.c: allocate buffer cache " Gioh Kim
2014-08-19 13:03 ` Jan Kara
2014-08-19 23:37 ` Gioh Kim
2014-08-20 2:16 ` Jan Kara
2014-08-20 2:38 ` Gioh Kim
2014-08-20 22:02 ` Jan Kara
2014-08-21 0:38 ` Gioh Kim
2014-08-19 6:53 ` [PATCHv2 2/3] ext4: allocate buffer-cache for superblock in non-movable area Gioh Kim
2014-08-19 6:54 ` Gioh Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F2F491.50208@lge.com \
--to=gioh.kim@lge.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=gunho.lee@lge.com \
--cc=jack@suse.cz \
--cc=js1304@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).