From: Gioh Kim <gioh.kim@lge.com>
To: Jan Kara <jack@suse.cz>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Theodore Ts'o" <tytso@mit.edu>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, "Minchan Kim" <minchan@kernel.org>,
"Joonsoo Kim" <js1304@gmail.com>, 이건호 <gunho.lee@lge.com>
Subject: Re: [PATCHv2 1/3] fs/buffer.c: allocate buffer cache with user specific flag
Date: Wed, 20 Aug 2014 11:38:10 +0900 [thread overview]
Message-ID: <53F40A12.6040506@lge.com> (raw)
In-Reply-To: <20140820021623.GB3271@quack.suse.cz>
>>>> @@ -1381,12 +1383,7 @@ EXPORT_SYMBOL(__find_get_block);
>>>> struct buffer_head *
>>>> __getblk(struct block_device *bdev, sector_t block, unsigned size)
>>>> {
>>>> - struct buffer_head *bh = __find_get_block(bdev, block, size);
>>>> -
>>>> - might_sleep();
>>>> - if (bh == NULL)
>>>> - bh = __getblk_slow(bdev, block, size);
>>>> - return bh;
>>>> + return __getblk_gfp(bdev, block, size, __GFP_MOVABLE);
>>>> }
>>>> EXPORT_SYMBOL(__getblk);
>>> Why did you remove the __find_get_block() call? That looks like a bug.
> I'm not sure if you didn't miss this comment....
I'm sorry I missed it.
I think calling __find_get_block() in __getblk_gfp() can replace it.
I'm not sure about it.
If anybody disagree with it, I'll change it as the original code.
next prev parent reply other threads:[~2014-08-20 2:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 6:51 [PATCHv2 0/3] new APIs to allocate buffer-cache with user specific flag Gioh Kim
2014-08-19 6:52 ` [PATCHv2 1/3] fs/buffer.c: allocate buffer cache " Gioh Kim
2014-08-19 13:03 ` Jan Kara
2014-08-19 23:37 ` Gioh Kim
2014-08-20 2:16 ` Jan Kara
2014-08-20 2:38 ` Gioh Kim [this message]
2014-08-20 22:02 ` Jan Kara
2014-08-21 0:38 ` Gioh Kim
2014-08-19 6:53 ` [PATCHv2 2/3] ext4: allocate buffer-cache for superblock in non-movable area Gioh Kim
2014-08-19 6:54 ` [PATCHv2 3/3] jbd/jbd2: allocate buffer-cache for superblock inode " Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F40A12.6040506@lge.com \
--to=gioh.kim@lge.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=gunho.lee@lge.com \
--cc=jack@suse.cz \
--cc=js1304@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).