From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233AC5695 for ; Thu, 9 Apr 2026 16:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775753502; cv=none; b=MKmBc/3QZZrF4jhTJl23bIEEV8NnqSnpPaDmn0U1w8ZYi5YnEyO1gPpJOCwc+2Hw9ISrT0KdiIdv5BQZ4QZ/vfKOkr4J4iSt+bD3FhSBKxZl6VT9rZCBIxYiMndSXs2Qs/fUII7EsL/9xDuaGkR8Y4xNGEbAjdHeI9hfMUA3o74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775753502; c=relaxed/simple; bh=Ie9Zxw2UvllTB7YlQnNnFk2N1eM27sHnKpf14ZlWn5U=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I7qmA82ANGhfJlMTCBmof+Xy3bgZR10Lh20K/FPAr/yTaxE7ZZliVKFexcqrcoemX/roq8blo/hGW6ihFuIkZeldDcDND2dL1hLwWhUrT5yS6j5/MeOzQeKLzV/wTyiU/Bv7DuXho5yBNI/1ab7M2an/oi+VWUG6yQESWJovxGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=amVr3deb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="amVr3deb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6E56C4CEF7; Thu, 9 Apr 2026 16:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775753501; bh=Ie9Zxw2UvllTB7YlQnNnFk2N1eM27sHnKpf14ZlWn5U=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=amVr3debZu4mSnspvhu0j8zH0sZ4Mz1vIKTgaedrslSuESCFmEW06wrwc3UBOMd4n BmC9WiT0uqPbK19jsyn7DDGcmeNRJqq5diMGKW37ECRGwITAinmcBBJLR1M16zJOk7 ai4wkdysxKfX71IuH3up2ZrljM818gNBRYrtLhn6Z3FhKJot8zfX46fboRxRfeczy4 PIQ5vgedHqiiPDU4A3mBUNk+WH7XjHIFzjezzRoTxYN+gWoHTwb2r5Qg/GaHp/ev9m Np7QG2XvCqG8/YaqbXpr4g+XD9s3o73QdvIWErFQ3jDICU/kZ2OeZPVaYL78JI/qpi ARsCnNuGTGHXA== Message-ID: <53b4795292d1df2fe1569fc724325ab52fcab322.camel@kernel.org> Subject: Re: [RFC PATCH v3 0/4] getting rid of busy-wait in shrink_dcache_parent() From: Jeff Layton To: Al Viro , Linus Torvalds Cc: linux-fsdevel@vger.kernel.org, Christian Brauner , Jan Kara , Nikolay Borisov , Max Kellermann , Eric Sandeen , Paulo Alcantara Date: Thu, 09 Apr 2026 12:51:38 -0400 In-Reply-To: <20260404080751.2526990-1-viro@zeniv.linux.org.uk> References: <20260122202025.GG3183987@ZenIV> <20260404080751.2526990-1-viro@zeniv.linux.org.uk> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-04-04 at 09:07 +0100, Al Viro wrote: > Changes since v2: > * separate select_data from the completion list elements - add a separat= e > struct completion_list (private to fs/dcache.c at the moment, but it's co= mpletely > independent from struct dentry and can be lifted e.g. into linux/completi= on.h > if there are other potential users). >=20 > Branch (currently -rc6-based) lives in > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.dcache-b= usy-wait > individual patches in followups. Please, review. >=20 > Shortlog: > Al Viro (4): > for_each_alias(): helper macro for iterating through dentries of given = inode > struct dentry: make ->d_u anonymous > dcache.c: more idiomatic "positives are not allowed" sanity checks > get rid of busy-waiting in shrink_dcache_tree() >=20 > Diffstat: > Documentation/filesystems/porting.rst | 10 ++ > fs/affs/amigaffs.c | 2 +- > fs/ceph/mds_client.c | 4 +- > fs/dcache.c | 129 +++++++++++++++++++------- > fs/exportfs/expfs.c | 2 +- > fs/inode.c | 2 +- > fs/nfs/dir.c | 4 +- > fs/nfs/getroot.c | 2 +- > fs/notify/fsnotify.c | 2 +- > fs/ocfs2/dcache.c | 2 +- > fs/overlayfs/dir.c | 2 +- > fs/smb/client/inode.c | 2 +- > include/linux/dcache.h | 24 ++++- > 13 files changed, 140 insertions(+), 47 deletions(-) >=20 > Series overview >=20 > First a couple of cleanups to reduce the amount of noise: >=20 > 1) for_each_alias(): helper macro for iterating through dentries of given= inode >=20 > Most of the places using d_alias are loops iterating through all aliases = for > given inode; introduce a helper macro (for_each_alias(dentry, inode)) > and convert open-coded instances of such loop to it. >=20 > They are easier to read that way and it reduces the noise on the next ste= ps. >=20 > 2) struct dentry: make ->d_u anonymous >=20 > Making ->d_rcu and (then) ->d_child overlapping dates back to 2006; anon = unions > support had been added to gcc only in 4.6 (2011) and the minimal gcc vers= ion hadn't > been bumped to that until 4.19 (2018). > These days there's no reason not to keep that union named. >=20 > Next we get rid of the aforementioned pathologies: >=20 > 3) dcache.c: more idiomatic "positives are not allowed" sanity checks >=20 > Several functions have BUG_ON/WARN_ON sanity checks that want to verify > that dentry is not positive and instead of looking at ->d_inode (as we > do in all other places that check that) they look at ->d_alias. > Just use the normal helpers instead - that way we no longer even look > at ->d_alias for negative dentries >=20 > Now that everything is ready for adding a new member and killing busy-wai= t: >=20 > 4) get rid of busy-waiting in shrink_dcache_tree() >=20 > If shrink_dcache_tree() runs into a potential victim that is already > dying, it must wait for that dentry to go away. To avoid busy-waiting > we need some object to wait on and a way for dentry_unlist() to see that > we need to be notified. >=20 > The obvious place for the object to wait on would be on our stack frame. > We will store a pointer to that object (struct completion_list) in victim > dentry; if there's more than one thread wanting to wait for the same > dentry to finish dying, we'll have their instances linked into a list, > with reference in dentry pointing to the head of that list. >=20 > * new object - struct completion_list. A pair of struct completion and > pointer to the next instance. That's what shrink_dcache_tree() will wait > on if needed. >=20 > * add a new member (->waiters, opaque pointer to struct completion_list) > to struct dentry. It is defined for negative live dentries that are > not in-lookup ones and it will remain NULL for almost all of them. >=20 > It does not conflict with ->d_rcu (defined for killed dentries), ->d_alia= s > (defined for positive dentries, all live) or ->d_in_lookup_hash (defined > for in-lookup dentries, all live negative). That allows to colocate > all four members. >=20 > * make sure that all places where dentry enters the state where ->waiters > is defined (live, negative, not-in-lookup) initialize ->waiters to NULL. >=20 > * if select_collect2() runs into a dentry that is already dying, have > its caller insert a local instance of struct completion_list into the > head of the list hanging off dentry->waiters and wait for completion. >=20 > * if dentry_unlist() sees non-NULL ->waiters, have it carefully walk > through the completion_list instances in that list, calling complete() > for each. >=20 > For now struct completion_list is local to fs/dcache.c; it's obviously > dentry-agnostic, and it can be trivially lifted into linux/completion.h > if somebody finds a reason to do so... >=20 >=20 This all looks good, Al. Nice work. I like the new wrappers and anon union too -- makes the code a lot more readable. I can also confirm that this fixes the livelock we were seeing as a precursor to this UAF [1]. I'm still not 100% sure how that livelock leads to a UAF. Claude thinks is has to do with the livelock making the loop outlive an RCU grace period. I did eventually find a vmcore and was able to confirm some things: - in the freed/reallocated dentry, most of the fields are clobbered, but the d_lru list pointers seemed to be intact. That tells me that the sucker was added to the shrink list after being freed and reallocated. That means that the WARN_ON_ONCE() wouldn't have caught this anyway. - there was some list corruption too: it looked like there were two different (on-stack) list heads in the list. There were also some dentries in there that were outside the shrin Note that this was an older (v6.13-based) kernel though, and it's possible there are other unfixed bugs in here. I'm currently trying to reproduce the UAF using that mdelay() based fault injection patch on something closer to mainline. [1]: https://lore.kernel.org/linux-fsdevel/20260406-dcache-warn-v1-1-c665ef= bc005f@kernel.org/ I reviewed the version in your work.dcache-busy-wait branch, but you can add this to the lot. Reviewed-by: Jeff Layton