From: Pavel Begunkov <asml.silence@gmail.com>
To: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, stable@vger.kernel.org,
axboe@kernel.dk, io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: Try to merge io requests only for regular files
Date: Fri, 19 Mar 2021 10:23:14 +0000 [thread overview]
Message-ID: <53e87077-88dc-26e3-40e7-a440afb3b0d0@gmail.com> (raw)
In-Reply-To: <20210319052859.3220-1-dmtrmonakhov@yandex-team.ru>
On 19/03/2021 05:28, Dmitry Monakhov wrote:
> Otherwise we may endup blocking on pipe or socket.
CC: io-uring ml
>
> Fixes: 6d5d5ac ("io_uring: extend async work merge")
> Testcase: https://github.com/dmonakhov/liburing/commit/16d171b6ef9d68e6db66650a83d98c5c721d01f6
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
> ---
> fs/io_uring.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 478df7e..848657c 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -2183,6 +2183,9 @@ static int __io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req,
> static struct async_list *io_async_list_from_req(struct io_ring_ctx *ctx,
> struct io_kiocb *req)
> {
> + if (!(req->flags & REQ_F_ISREG))
> + return NULL;
> +
> switch (req->submit.opcode) {
> case IORING_OP_READV:
> case IORING_OP_READ_FIXED:
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-03-19 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 5:28 [PATCH] io_uring: Try to merge io requests only for regular files Dmitry Monakhov
2021-03-19 6:36 ` Greg KH
2021-03-19 7:45 ` Dmitry Monakhov
2021-03-19 10:23 ` Pavel Begunkov [this message]
2021-03-19 14:06 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53e87077-88dc-26e3-40e7-a440afb3b0d0@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).