From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [Cluster-devel] [PATCH][try6] VFS: new want_holesize and got_holesize
 buffer_head flags for fiemap
Date: Wed, 22 Oct 2014 11:50:39 +0100
Message-ID: <54478BFF.8070608@redhat.com>
References: <635673293.9099204.1413939501068.JavaMail.zimbra@redhat.com> <579956475.9102148.1413940195344.JavaMail.zimbra@redhat.com> <20141022060434.GA11237@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, Alexander Viro <aviro@redhat.com>,
	cluster-devel <cluster-devel@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
	Bob Peterson <rpeterso@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51675 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932320AbaJVKvF (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 22 Oct 2014 06:51:05 -0400
In-Reply-To: <20141022060434.GA11237@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi,

On 22/10/14 07:04, Christoph Hellwig wrote:
> This looks like a big indicator that get_blocks is the wrong
> interface for fiemap.
>

The question is then, what a better interface would look like? We could 
have "get_hole" as an extra operation I suppose. Not sure that I really 
see why thats better or worse than the extra flag at the moment? or did 
you have something else in mind?

Steve.