From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [RFC][PATCH v3 2/6] encrypted-keys: added additional debug messages
Date: Wed, 26 Jan 2011 10:49:29 +0000
Message-ID: <5456.1296038969@redhat.com>
References: <1295887497-20198-3-git-send-email-roberto.sassu@polito.it> <1295887497-20198-1-git-send-email-roberto.sassu@polito.it>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@linux-nfs.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, jmorris@namei.org,
	zohar@linux.vnet.ibm.com, safford@watson.ibm.com,
	ramunno@polito.it, tyhicks@linux.vnet.ibm.com,
	kirkland@canonical.com
To: Roberto Sassu <roberto.sassu@polito.it>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1295887497-20198-3-git-send-email-roberto.sassu@polito.it>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Roberto Sassu <roberto.sassu@polito.it> wrote:

> +		pr_err("encrypted_key: insufficient parameters specified\n");

I think pr_err() is probably too high a message level.  This is a user error
not a kernel error.  I would recommend something like pr_info() or possibly
pr_debug().

David