Re: [PATCH 1/4] pmem: Initial version of persistent memory driver

[Boaz Harrosh <boaz@plexistor.com>]

On 11/04/2014 06:41 PM, Ross Zwisler wrote:
<>
> 
> The UEFI organization is in the process of defining a generic specification
> for platform non-volatile memory resources.  Essentially the thought was to
> wait until that was publicly available before adding any new device discovery
> capabilities to pmem.
> 
> What Boaz has suggested and coded up is certainly useful, but the worry is
> that it will end up being incompatible with what comes out of UEFI.  If we
> stay with the dead-simple module parameter method, we will have less code to
> unwind later.
> 

What ??
What I coded up is a exactly "dead-simple module parameter method"
that will not need to be changed in future, that is actually sane.

Actually your version of the code needs changing with the global parameters,
one range support, and same size devices.

My version of the code is specifically made very probe() ready and dynamic
ready. It was the point of it all. Including bugs and ugliness fixed.
(I have a small patch that dynamically addes/removes devices on the fly
 through the same module-param interface)

There is not a line in all of my patches that might be affected by
that UEFI comity. (Again actually fixing what needed changing). And in
addition to that comity and the new HW they will define, my system
also supports all the current NvDIMMs in the market.

I really can not understand what you guys are saying? Have you actually
looked at the code and used it, compared to the unusable thing you guys
have now ??
[Like you are saying "before adding any new device discovery capabilities"
 But I have not added any? All I did was fix and simplify the module-param
 interface. Which makes me think that you might not have looked at any of
 my fixes?
]

> Thanks,
> - Ross

Cheers
Boaz