From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernd Schubert Subject: Re: [RFC] Discard update for 3.19 Date: Fri, 07 Nov 2014 13:09:25 +0100 Message-ID: <545CB675.7050308@ddn.com> References: <1415336894-15327-1-git-send-email-martin.petersen@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: linux-fsdevel@vger.kernel.org Return-path: Received: from plane.gmane.org ([80.91.229.3]:41447 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbaKGMkH (ORCPT ); Fri, 7 Nov 2014 07:40:07 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Xmipg-0000Th-EJ for linux-fsdevel@vger.kernel.org; Fri, 07 Nov 2014 13:40:04 +0100 Received: from 109.237.241.80 ([109.237.241.80]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Nov 2014 13:40:04 +0100 Received: from bschubert by 109.237.241.80 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 07 Nov 2014 13:40:04 +0100 In-Reply-To: <1415336894-15327-1-git-send-email-martin.petersen@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > The second patch tweaks the SCSI disk driver to prefer WRITE SAME w/ > UNMAP instead of the UNMAP command since the former has deterministic > behavior. I have seen data corruption on an Intel SSD 510 after sending WRITE SAME UNMAP. As far as I remember, these disks ignore writes after sending that command. Unmap worked fine, though. Cheers, Bernd