From: Boaz Harrosh <boaz@plexistor.com>
To: Dave Chinner <david@fromorbit.com>, Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH,RFC] ext4: add lazytime mount option
Date: Thu, 13 Nov 2014 10:44:59 +0200 [thread overview]
Message-ID: <54646F8B.8040000@plexistor.com> (raw)
In-Reply-To: <20141113064150.GI28565@dastard>
On 11/13/2014 08:41 AM, Dave Chinner wrote:
<>
>
> I think this needs to a VFS level inode timestamp update option.
> The games ext4 is playing with reference counts inside .drop_inode are
> pretty nasty and could be avoided if this is implemented at the VFs
> level..
>
> I think that the "lazy time update" status should really be tracked
> in the inode->i_state field. Something like lazytime updates do not
> call ->update_inode, nor do they mark the inode dirty, but they do
> update the inode->i_[acm]time fields and set a TIMEDIRTY state flag.
>
> Then when the filesystem next logs or writes the inode it can
> log those fields and clear the TIMEDIRTY flag, or if iput_final()
> sees that flag it can call ->update_time directly to get the
> filesystem to run a transaction to update the timestamps before the
> inode is evicted from cache.
>
> That way the same update semantics can be easily implemented on all
> filesystems, and filesystems that already implement update_time
> should work without any modification at all...
>
+1 Like from Boaz. I think Dave is very much right!
> Cheers,
Indeed
Boaz
> Dave.
<>
next prev parent reply other threads:[~2014-11-13 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1415765227-9561-1-git-send-email-tytso@mit.edu>
2014-11-13 6:41 ` [PATCH,RFC] ext4: add lazytime mount option Dave Chinner
2014-11-13 8:44 ` Boaz Harrosh [this message]
2014-11-13 16:35 ` Theodore Ts'o
2014-11-13 20:48 ` Dave Chinner
2014-11-13 21:34 ` Theodore Ts'o
2014-11-13 22:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54646F8B.8040000@plexistor.com \
--to=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).