From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89735C761A6 for ; Wed, 29 Mar 2023 23:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbjC2XiX (ORCPT ); Wed, 29 Mar 2023 19:38:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjC2XiR (ORCPT ); Wed, 29 Mar 2023 19:38:17 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 086721FC1 for ; Wed, 29 Mar 2023 16:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133096; x=1711669096; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=trSlsKzGDIdMPkatCLLhm/IW4lDqvQLyF89j6Acxt+c=; b=Gj56nBHQauwY/wGbYU86+5tVcTdrG79qOgq1eT4Zhs0sxoAm0ti4+YqP EuIXDb+uCg6xyEGGh/wOXcrblsIr329N2xJu0jMie/Jxv8hZ26kciGNbF 4KD0IgprTkmFmmhtoZ3DR4kwltcda9nbTquiqGtqDikg4muOR6Zmn5uZ1 HFAyaQKKXZ79acRgUX3Ntbb/8gz1/zMk+/xT0+dNZcnutnY7Dgi5YxE8U Khy7nVCPaVHF7k0tBAaIDo+fO1K8YvZ6C/l0o/gyGw1ZtjHC02s5ABo4M YbXYK/ilBSgyYp1hCOj0W0QLjiV50y3BjXqemposPTp3quHIY3Ad4GM3O g==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648450" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:38:15 +0800 IronPort-SDR: EqtKWZw0SZ6E5hKO4NwArLxl+19IWjmxX/6w8+2KHIxrqoWEPvkMGtTqNTctjQ5O+jG0VGCFCt RHMFzkXicqz1+eIUyvcSX8Nraci5AwpVM/Az4AQrIhs/JL44JMBte2EMeQ3h0yFJ+JwokdY9PL vhMGzTfjeQ0T8NvO71j9CcL44Ni4zjWwjIfam/N4R6N3xjqXBoH3l+jfIB+zwREUgYbOm2CHme 5F/tm1EgpPHpYZTh56YvOWRQ8Uqds2N6zt9+wpaOk+X+j65IKuEgy3EUVJb3USTOpk+E/xdOq4 GBk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:54:24 -0700 IronPort-SDR: nW8BcFMRbjfOhoV/eYBk+xDnSMC6gUTlPoZGJzkQ3XDoiVDJYHw2y6mwspS61P110KGS0IdLjb z8TUYm8ABialSVOBgAIcwxW/RUahh6znn7oMYUXytou6IIOGjS1DZPU2uW9ek401aIXWx/iu7F SjNuVow06HmuBGVJ12HdQ8suLVNeba0HyZBsjqiVBgKerXQ8xrLvCcH9ABZt8dO3R+p7qZqcUE 7mtNo63nQxAUeextsOkrnh25Z/BKDcQo9EIju3La0SmEsihBElJ8wE1uXbtglEf1tvQSWota9G Ayg= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:38:16 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2zq0xbzz1RtVx for ; Wed, 29 Mar 2023 16:38:15 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133094; x=1682725095; bh=trSlsKzGDIdMPkatCLLhm/IW4lDqvQLyF89 j6Acxt+c=; b=IwLM6OxTQ5LWzxAC4NcyXZ1dr2nvfgOzo9MYnLjHJuGsYvXhajL hlDO/OUe2nXi2knwvLTDrpf7NjCBruC2QzmIpB4JE9IyVsUJJAG/YLLsSyvDJh6t qxwxrHBhyTsmBCFnvPnxGjsvWVabw/lioMS9Htl+JJJqa4JvEgAHA2zECs+RUwul t+dnEFKBLZOQyEWCGPk1uA6JA048hYHWTFe/WWVJRogq+WSguIeHywIZ5y4oQkjK dU94SWBhAlGUm9MArYUGt90AtfkGpTivTX688Qa5D0tXrxVoC2lWcu6DZA0NboRO DWfvkb0SzT2gUKXzOI9on0y1QnPiBSGbu9w== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vY8Gs0pkPRES for ; Wed, 29 Mar 2023 16:38:14 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2zl2Krzz1RtVm; Wed, 29 Mar 2023 16:38:11 -0700 (PDT) Message-ID: <546786e3-79b3-f9d0-008c-23d2de7eb3de@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:38:10 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 15/19] md: check for failure when adding pages in alloc_behind_master_bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <76f5748e386870c034b46e919101a878b87a79bf.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <76f5748e386870c034b46e919101a878b87a79bf.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 3/30/23 02:06, Johannes Thumshirn wrote: > alloc_behind_master_bio() can possibly add multiple pages to a bio, but it > is not checking for the return value of bio_add_page() if adding really > succeeded. > > Check if the page adding succeeded and if not bail out. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research