From: hujianyang <hujianyang@huawei.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
<linux-unionfs@vger.kernel.org>
Subject: Re: Xattr issues with overlayfs
Date: Wed, 26 Nov 2014 16:09:13 +0800 [thread overview]
Message-ID: <54758AA9.9020906@huawei.com> (raw)
In-Reply-To: <CAJfpegtvTZYk2V7a94g_CDKhw4Fn8_bS-cSJKHWHqvvU4abygg@mail.gmail.com>
On 2014/11/25 22:41, Miklos Szeredi wrote:
>
> No, I don't think this makes any sense. Maintenance can be done by
> unmounting the overlay and doing modification directly on the upper
> layer. After this is done (adding/removing opaque flag, adding
> removing whiteouts, etc) the overlay can be mounted again and the
> modifications will be applied.
Yes, we can remove overlayfs_xattr directly on upper files.
>
> I don't think online modification of the internal attributes of the
> overlay makes much sense.
>
> Except maybe, maybe a privileged undelete, but even that one is
> tricky: the whiteout was either from deletion of the lower layer or
> the upper layer file, the later not being undeleteable. But the two
> cases are currently indistinguishable, so the undelete would always
> recover the lower layer file, which is probably not what the user
> wants and might cause more harm than good.
>
Agree.
Thanks for your explanation. Now I know "trusted.overlay.opaque" can
be set in userspace, but this xattr is set on files in upper filesystem,
not directly on files in overlayfs.
Thanks~!
Hu
prev parent reply other threads:[~2014-11-26 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 10:16 Xattr issues with overlayfs hujianyang
2014-11-24 10:25 ` [PATCH] ovl: Use macros to present ovl_xattr hujianyang
2014-11-24 10:30 ` [PATCH] ovl: Enable opauqe setting an removing in userspace hujianyang
2014-11-25 14:41 ` Xattr issues with overlayfs Miklos Szeredi
2014-11-26 8:09 ` hujianyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54758AA9.9020906@huawei.com \
--to=hujianyang@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).