linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever III <chuck.lever@oracle.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove reference to the removed config NFSD_V3
Date: Fri, 11 Mar 2022 15:54:39 +0000	[thread overview]
Message-ID: <54AB09CE-9345-4C8C-84F8-FA5C8D9F9EB9@oracle.com> (raw)
In-Reply-To: <9A70DCDF-2F9D-4020-B936-380D919421D4@oracle.com>



> On Mar 11, 2022, at 10:23 AM, Chuck Lever III <chuck.lever@oracle.com> wrote:
> 
> 
> 
>> On Mar 11, 2022, at 9:39 AM, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>> 
>> Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config
>> NFSD_V3, but misses one reference in fs/Kconfig.
>> 
>> Remove this remaining reference to the removed config symbol.
>> 
>> This issue was discovered with ./scripts/checkkconfigsymbols.py.
>> 
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>> ---
>> Chuck, please pick this quick fix to your commit in linux-next.
>> 
>> fs/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/fs/Kconfig b/fs/Kconfig
>> index 7f2455e8e18a..ec2cf8ccd170 100644
>> --- a/fs/Kconfig
>> +++ b/fs/Kconfig
>> @@ -344,7 +344,7 @@ config LOCKD
>> 
>> config LOCKD_V4
>> 	bool
>> -	depends on NFSD_V3 || NFS_V3
>> +	depends on NFS_V3
> 
> Actually, I think:
> 
> 	depends on NFSD || NFS_V3
> 
> is more correct. LOCKD_V4 now needs to be enabled whenever
> the server is enabled, since NFSv3 support in the server is
> now always enabled.

I've squashed this change into "NFSD: Remove CONFIG_NFSD_V3".
Thanks for reporting it, Lukas!


>> 	depends on FILE_LOCKING
>> 	default y
>> 
>> -- 
>> 2.17.1
>> 
> 
> --
> Chuck Lever

--
Chuck Lever




      reply	other threads:[~2022-03-11 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 14:39 [PATCH] fs: remove reference to the removed config NFSD_V3 Lukas Bulwahn
2022-03-11 15:23 ` [PATCH] " Chuck Lever III
2022-03-11 15:54   ` Chuck Lever III [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AB09CE-9345-4C8C-84F8-FA5C8D9F9EB9@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).