linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <boaz@plexistor.com>
To: Jens Axboe <axboe@fb.com>, Matthew Wilcox <willy@linux.intel.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCHSET 0/4 v4] brd: partition fixes
Date: Wed, 07 Jan 2015 18:02:27 +0200	[thread overview]
Message-ID: <54AD5893.9040701@plexistor.com> (raw)

Jens Hi

Currently brd has multiple bugs when trying to use partitions. After this
set all known problems are solved. Please see individual patch for description
of the problem.
(Another merge window, another patchset send. I wish you would tell me to
 just *uck-off, instead of this silence. What is so big a deal about this
 simple bug fixes.)

These should go into current v3.19-rcXX merge window they are real bugs
solving Data corruption, when using partitions.

[v4]
- Rebase to 3.19-rc3
- Removed the getgeo patch it is no longer needed by new fdisk
- Minor change to patch: [4/4] brd: Request from fdisk 4k alignment
  As suggested by Martin

[v3]
Same exact code but some commit messages changed to try and explain better
what was fixed and why. (Rebased on 3.18-rc3 but nothing changed in brd.c
since then)

[v2]
Based on Jens's linux-next [30e996a] incorporating the brd patch by Dmitry Monakhov.
Dmitry has introduced a new part_show parameter, this parameter is now removed
and we always "part_show=1".
Scripts that did part_show=1 will work just the same but will display a
message in logs. This is harmless. (And scripts can be modified to
remove this parameter)

[v1]
Current situation is that any attempt to use partitions with brd device would
create the partition but then any use will trash the data.

See: http://www.spinics.net/lists/linux-scsi/msg76737.html

So these patches fixes up all the problems we saw with the code, but not sacrificing
any of the old fixtures. See [patch 3/4] for more explanations.

list of patches:
[PATCH 1/4] axonram: Fix bug in direct_access
[PATCH 2/4] block: Change direct_access calling convention

	These 2 above are from Matthew's DAX series latest version.
	Exactly as is, taken from the 01org/prd.git tree
	They are needed so to support direct_access with partitions.

[PATCH 3/4] brd: Fix all partitions BUGs

	This one fixes all the very HARD bugs, which today
	cause data corruption.

[PATCH 4/4] brd: Request from fdisk 4k alignment

One can fetch/view these patches from a public tree here:
  git: git://git.open-osd.org/pmem.git brd-partitions branch
  web: http://git.open-osd.org/gitweb.cgi?p=pmem.git;a=shortlog;h=refs/heads/brd-partitions

Thanks
Boaz


             reply	other threads:[~2015-01-07 16:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 16:02 Boaz Harrosh [this message]
2015-01-07 16:04 ` [PATCH 1/4 v4] axonram: Fix bug in direct_access Boaz Harrosh
2015-01-07 16:05 ` [PATCH 2/4 v4] block: Change direct_access calling convention Boaz Harrosh
2015-01-07 16:07 ` [PATCH 3/4 v4] brd: Fix all partitions BUGs Boaz Harrosh
2015-01-16 22:32   ` Tony Luck
2015-01-16 22:49     ` Jens Axboe
2015-01-18 13:08       ` Boaz Harrosh
2015-01-18 15:10         ` Christoph Hellwig
2015-01-18 15:32           ` [RFC] block: Remove annoying "unknown partition table" message Boaz Harrosh
2015-01-18 15:48             ` Boaz Harrosh
2015-01-20 21:50               ` Jens Axboe
2015-01-22 12:39                 ` [PATCH] " Boaz Harrosh
2015-01-22 12:47                   ` Boaz Harrosh
2015-01-07 16:09 ` [PATCH 4/4 v4] brd: Request from fdisk 4k alignment Boaz Harrosh
2015-01-08 15:37   ` Martin K. Petersen
2015-01-08 20:56 ` [PATCHSET 0/4 v4] brd: partition fixes Jens Axboe
2015-01-11  9:30   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD5893.9040701@plexistor.com \
    --to=boaz@plexistor.com \
    --cc=axboe@fb.com \
    --cc=dmonakhov@openvz.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).