linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <boaz@plexistor.com>
To: Jens Axboe <axboe@fb.com>, Matthew Wilcox <willy@linux.intel.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 1/4 v4] axonram: Fix bug in direct_access
Date: Wed, 07 Jan 2015 18:04:18 +0200	[thread overview]
Message-ID: <54AD5902.1000204@plexistor.com> (raw)
In-Reply-To: <54AD5893.9040701@plexistor.com>

From: Matthew Wilcox <matthew.r.wilcox@intel.com>

The 'pfn' returned by axonram was completely bogus, and has been since
2008.

Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: stable@vger.kernel.org
---
 arch/powerpc/sysdev/axonram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c
index f532c92..367533b 100644
--- a/arch/powerpc/sysdev/axonram.c
+++ b/arch/powerpc/sysdev/axonram.c
@@ -156,7 +156,7 @@ axon_ram_direct_access(struct block_device *device, sector_t sector,
 	}
 
 	*kaddr = (void *)(bank->ph_addr + offset);
-	*pfn = virt_to_phys(kaddr) >> PAGE_SHIFT;
+	*pfn = virt_to_phys(*kaddr) >> PAGE_SHIFT;
 
 	return 0;
 }
-- 
1.9.3

  reply	other threads:[~2015-01-07 16:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 16:02 [PATCHSET 0/4 v4] brd: partition fixes Boaz Harrosh
2015-01-07 16:04 ` Boaz Harrosh [this message]
2015-01-07 16:05 ` [PATCH 2/4 v4] block: Change direct_access calling convention Boaz Harrosh
2015-01-07 16:07 ` [PATCH 3/4 v4] brd: Fix all partitions BUGs Boaz Harrosh
2015-01-16 22:32   ` Tony Luck
2015-01-16 22:49     ` Jens Axboe
2015-01-18 13:08       ` Boaz Harrosh
2015-01-18 15:10         ` Christoph Hellwig
2015-01-18 15:32           ` [RFC] block: Remove annoying "unknown partition table" message Boaz Harrosh
2015-01-18 15:48             ` Boaz Harrosh
2015-01-20 21:50               ` Jens Axboe
2015-01-22 12:39                 ` [PATCH] " Boaz Harrosh
2015-01-22 12:47                   ` Boaz Harrosh
2015-01-07 16:09 ` [PATCH 4/4 v4] brd: Request from fdisk 4k alignment Boaz Harrosh
2015-01-08 15:37   ` Martin K. Petersen
2015-01-08 20:56 ` [PATCHSET 0/4 v4] brd: partition fixes Jens Axboe
2015-01-11  9:30   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD5902.1000204@plexistor.com \
    --to=boaz@plexistor.com \
    --cc=axboe@fb.com \
    --cc=dmonakhov@openvz.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).