From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@suse.cz>,
akpm@linux-foundation.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: compaction tracepoint broken with CONFIG_COMPACTION enabled
Date: Mon, 19 Jan 2015 15:38:34 +0100 [thread overview]
Message-ID: <54BD16EA.9050007@suse.cz> (raw)
In-Reply-To: <20150119124210.GC21052@dhcp22.suse.cz>
On 01/19/2015 01:42 PM, Michal Hocko wrote:
> Hi,
> compaction trace points seem to be broken without CONFIG_COMPACTION
> enabled after
> mm-compaction-more-trace-to-understand-when-why-compaction-start-finish.patch.
>
> My config is
> # CONFIG_COMPACTION is not set
> CONFIG_CMA=y
Joonsoo posted a V4 that should be fixed at least according to description -
unfortunately it wasn't just fixes on top of what's in mmotm, though.
> which might be a bit unusual but I am getting
> CC mm/compaction.o
> In file included from include/trace/define_trace.h:90:0,
> from include/trace/events/compaction.h:298,
> from mm/compaction.c:49:
> include/trace/events/compaction.h: In function ‘ftrace_raw_output_mm_compaction_end’:
> include/trace/events/compaction.h:164:3: error: ‘compaction_status_string’ undeclared (first use in this function)
> compaction_status_string[__entry->status])
> ^
> [...]
> include/trace/events/compaction.h: In function ‘ftrace_raw_output_mm_compaction_suitable_template’:
> include/trace/events/compaction.h:220:3: error: ‘compaction_status_string’ undeclared (first use in this function)
> compaction_status_string[__entry->ret])
> [...]
> scripts/Makefile.build:257: recipe for target 'mm/compaction.o' failed
> make[1]: *** [mm/compaction.o] Error 1
> Makefile:1528: recipe for target 'mm/compaction.o' failed
> make: *** [mm/compaction.o] Error 2
>
> Moving compaction_status_string outside of CONFIG_COMPACTION doesn't
> help much because of other failures:
> include/trace/events/compaction.h:261:30: error: ‘struct zone’ has no member named ‘compact_defer_shift’
> __entry->defer_shift = zone->compact_defer_shift;
>
> So I guess the tracepoint need a better fix.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-01-19 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 23:50 mmotm 2015-01-16-15-50 uploaded akpm
2015-01-17 6:40 ` Guenter Roeck
2015-01-19 6:19 ` Joonsoo Kim
2015-01-19 12:42 ` compaction tracepoint broken with CONFIG_COMPACTION enabled (was: mmotm 2015-01-16-15-50 uploaded) Michal Hocko
2015-01-19 14:38 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD16EA.9050007@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).