From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [RFC] block: Remove annoying "unknown partition table" message Date: Tue, 20 Jan 2015 14:50:01 -0700 Message-ID: <54BECD89.7030404@fb.com> References: <54AD5893.9040701@plexistor.com> <54AD59DC.4020703@plexistor.com> <54B99591.7080007@fb.com> <54BBB048.7010207@plexistor.com> <20150118151059.GA17263@infradead.org> <54BBD225.3080200@plexistor.com> <54BBD5D7.6000802@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Tony Luck , Matthew Wilcox , Dmitry Monakhov , linux-kernel , linux-fsdevel , "Martin K. Petersen" To: Boaz Harrosh , Christoph Hellwig Return-path: In-Reply-To: <54BBD5D7.6000802@plexistor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 01/18/2015 08:48 AM, Boaz Harrosh wrote: > On 01/18/2015 05:32 PM, Boaz Harrosh wrote: >> From: Boaz Harrosh >> >> As Christoph put it best: >> Can we just get rid of the warnings? It's fairly annoying as devices >> without partitions are perfectly fine and very useful. >> >> Me too I see this message every VM boot for ages on all my >> devices. Would love to just remove it. For me a partition-table >> is only needed for a booting BIOS, grub, and stuff. >> >> (NOT Yet Tested) >> >> CC: Christoph Hellwig >> Signed-off-by: Boaz Harrosh >> --- >> block/partitions/check.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/block/partitions/check.c b/block/partitions/check.c >> index 9ac1df7..e3a9077 100644 >> --- a/block/partitions/check.c >> +++ b/block/partitions/check.c >> @@ -184,9 +184,7 @@ check_partition(struct gendisk *hd, struct block_device *bdev) >> if (err) >> /* The partition is unrecognized. So report I/O errors if there were any */ >> res = err; >> - if (!res) >> - strlcat(state->pp_buf, " unknown partition table\n", PAGE_SIZE); >> - else if (warn_no_part) >> + if (warn_no_part) >> strlcat(state->pp_buf, " unable to read partition table\n", PAGE_SIZE); >> >> printk(KERN_INFO "%s", state->pp_buf); >> > > Off course that was untested crap something like: > --- > diff --git a/block/partitions/check.c b/block/partitions/check.c > index 9ac1df7..16118d1 100644 > --- a/block/partitions/check.c > +++ b/block/partitions/check.c > @@ -184,12 +184,12 @@ check_partition(struct gendisk *hd, struct block_device *bdev) > if (err) > /* The partition is unrecognized. So report I/O errors if there were any */ > res = err; > - if (!res) > - strlcat(state->pp_buf, " unknown partition table\n", PAGE_SIZE); > - else if (warn_no_part) > - strlcat(state->pp_buf, " unable to read partition table\n", PAGE_SIZE); > - > - printk(KERN_INFO "%s", state->pp_buf); > + if (res) { > + if (warn_no_part) > + strlcat(state->pp_buf, > + " unable to read partition table\n", PAGE_SIZE); > + printk(KERN_INFO "%s", state->pp_buf); > + } > > free_page((unsigned long)state->pp_buf); > free_partitions(state); > --- > Not-Signed-off-yet: Boaz Harrosh Were you going to send a tested patch with the commit message? -- Jens Axboe