From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [Lsf-pc] [LSF/MM TOPIC] async buffered diskio read for userspace apps Date: Sat, 24 Jan 2015 16:00:44 -0700 Message-ID: <54C4241C.9070406@kernel.dk> References: <20150116165506.GA10856@samba2> <20150119071218.GA9747@jeremy-HP> <1421652849.2080.20.camel@HansenPartnership.com> <54BD234F.3060203@kernel.dk> <54C300A1.7040202@kernel.dk> <20150124055352.GE6636@jeremy-HP> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Steve French , Milosz Tanski , Volker Lendecke , James Bottomley , Jan Kara , Christoph Hellwig , linux-mm , "linux-fsdevel@vger.kernel.org" , "lsf-pc@lists.linux-foundation.org" To: Jeremy Allison Return-path: Received: from mail-pa0-f44.google.com ([209.85.220.44]:36783 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956AbbAXXAq (ORCPT ); Sat, 24 Jan 2015 18:00:46 -0500 Received: by mail-pa0-f44.google.com with SMTP id rd3so4332424pab.3 for ; Sat, 24 Jan 2015 15:00:45 -0800 (PST) In-Reply-To: <20150124055352.GE6636@jeremy-HP> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 01/23/2015 10:53 PM, Jeremy Allison wrote: > On Fri, Jan 23, 2015 at 07:17:05PM -0700, Jens Axboe wrote: >> On 01/23/2015 04:15 PM, Steve French wrote: >>> On Mon, Jan 19, 2015 at 10:20 AM, Milosz Tanski wrote: >>>> On Mon, Jan 19, 2015 at 11:10 AM, Volker Lendecke >>>> wrote: >>>>> On Mon, Jan 19, 2015 at 08:31:27AM -0700, Jens Axboe wrote: >>>>>> I didn't look at your code yet, but I'm assuming it's a self >>>>>> contained IO engine. So we should be able to make that work, by only >>>>>> linking the engine itself against libsmbclient. But sheesh, what a >>>>>> pain in the butt, why can't we just all be friends. >>>>> >>>>> The published libsmbclient API misses the async features >>>>> that are needed here. Milosz needs to go lower-level. >>>>> >>>>> Volker >>>> >>>> Volker, the sync code path works; in fact I pushed some minor >>>> corrections to my branch this morning. And for now using FIO I can >>>> generate multiple clients (threads / processes). >>>> >>>> I started working on the async features (SMB2 async read/write) for >>>> client library the samba repo. There's a patch there for the first >>>> step of it it there; see the other email I sent to you and Jeremy. I >>>> was going to make sure it licensed under whatever it needs to get into >>>> the samba repo... and since this is done on my own time I personally >>>> don't care what license it's under provided it's not a PITA. >>> >>> Why not do the async read/write via the kernel client if the license >>> is an issue? It already has async SMB2/SMB3 operations >>> (with a synchronous send/receive-like wrapper). >> >> The license issue has been solved. Fio is cross platform, so would >> be preferable to have this work through libsmbclient, if at all >> possible. > > How did the license issue get solved ? Did I miss some email > on that ? Only the cifs engine is linked with libsmbclient, so that particular engine can be licensed as v2 or later (or v3, u to Milosz). -- Jens Axboe