From: Boaz Harrosh <boaz@plexistor.com>
To: Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: shared/032 is broken on Fedora
Date: Wed, 11 Feb 2015 12:58:56 +0200 [thread overview]
Message-ID: <54DB35F0.1010203@plexistor.com> (raw)
This is not the proper patch just to show a working version for Fedora. But I think
it now breaks the other ARCHs.
What happens is that the output of ${MKFS_PROG}.* is:
/usr/sbin/mkfs.bfs /usr/sbin/mkfs.btrfs /usr/sbin/mkfs.cramfs /usr/sbin/mkfs.ext2 /usr/sbin/mkfs.ext3 /usr/sbin/mkfs.ext4 ...
So in Fedora sbin has moved to /usr/... and therefor the sed below fails.
My sed foo is not good enough. How to support both places for sbin?
Also why the "_supported_fs xfs btrfs"? So if all those other mkfs.* that are destructive to
foreign filesystem, should the test not fail instead of skipped?
Maybe if the maintainers of all these filesystems day in and day out running xfstests and
see shared/032 failing, they might decide to fix their evil ways. Instead of skipping the
test and the said maintainer just ignores it?
Thanks
Boaz
---
diff --git a/tests/shared/032 b/tests/shared/032
index a410003..726e6b4 100755
--- a/tests/shared/032
+++ b/tests/shared/032
@@ -37,8 +37,8 @@ rm -f $seqres.full
. ./common/filter
# real QA test starts here
-_supported_fs xfs btrfs
+# _supported_fs xfs btrfs
_supported_os Linux
_require_scratch_nocheck
_require_no_large_scratch_dev
@@ -49,8 +49,7 @@ if [ "$FSTYP" == "btrfs" ]; then
_notrun "Installed mkfs.btrfs does not support -f option"
fi
-echo "Silence is golden."
-for fs in `echo ${MKFS_PROG}.* | sed -e 's/.sbin.mkfs.//g'`
+for fs in `echo ${MKFS_PROG}.* | sed -e 's/.usr\/sbin.mkfs.//g'`
do
preop="" # for special input needs
preargs="" # for any special pre-device options
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2015-02-11 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 10:58 Boaz Harrosh [this message]
2015-02-11 13:10 ` shared/032 is broken on Fedora Boaz Harrosh
2015-02-11 16:50 ` Eric Sandeen
2015-02-11 16:55 ` Eric Sandeen
2015-02-11 17:23 ` Lukáš Czerner
2015-02-11 17:11 ` [PATCH] fstests: shared/032 handle mkfs.* in either /sbin or /usr/sbin Eric Sandeen
2015-02-11 17:36 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB35F0.1010203@plexistor.com \
--to=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).