From: Eric Sandeen <sandeen@sandeen.net>
To: Boaz Harrosh <boaz@plexistor.com>,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
fstests@vger.kernel.org
Subject: Re: shared/032 is broken on Fedora
Date: Wed, 11 Feb 2015 10:55:26 -0600 [thread overview]
Message-ID: <54DB897E.7060703@sandeen.net> (raw)
In-Reply-To: <54DB886D.9060201@sandeen.net>
On 2/11/15 10:50 AM, Eric Sandeen wrote:
> (cc: fstests list)
>
> On 2/11/15 4:58 AM, Boaz Harrosh wrote:
>>
>> This is not the proper patch just to show a working version for Fedora. But I think
>> it now breaks the other ARCHs.
>>
>> What happens is that the output of ${MKFS_PROG}.* is:
>> /usr/sbin/mkfs.bfs /usr/sbin/mkfs.btrfs /usr/sbin/mkfs.cramfs /usr/sbin/mkfs.ext2 /usr/sbin/mkfs.ext3 /usr/sbin/mkfs.ext4 ...
>>
>> So in Fedora sbin has moved to /usr/... and therefor the sed below fails.
>> My sed foo is not good enough. How to support both places for sbin?
>
> All we really want is the mkfs filesystem type, i.e. the ${FS} in mkfs.${FS}
>
> So
>
> sed -e 's/.*mkfs.//g'
Wait, no, I misunderstood what it was working on ;) Hang on ...
-Eric
next prev parent reply other threads:[~2015-02-11 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 10:58 shared/032 is broken on Fedora Boaz Harrosh
2015-02-11 13:10 ` Boaz Harrosh
2015-02-11 16:50 ` Eric Sandeen
2015-02-11 16:55 ` Eric Sandeen [this message]
2015-02-11 17:23 ` Lukáš Czerner
2015-02-11 17:11 ` [PATCH] fstests: shared/032 handle mkfs.* in either /sbin or /usr/sbin Eric Sandeen
2015-02-11 17:36 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB897E.7060703@sandeen.net \
--to=sandeen@sandeen.net \
--cc=boaz@plexistor.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).