From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH] brd: Only request 4K sectors if DAX is enabled Date: Sun, 01 Mar 2015 10:30:25 +0200 Message-ID: <54F2CE21.6080206@plexistor.com> References: <1424818479-10083-1-git-send-email-david@fromorbit.com> <1424818479-10083-2-git-send-email-david@fromorbit.com> <20150225161151.GC28053@bfoster.bfoster> <20150225223248.GH4251@dastard> <54EED5F6.2030804@plexistor.com> <54EEDC4A.8090000@plexistor.com> <20150227002302.GF18360@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Jens Axboe , Brian Foster , fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dave Chinner Return-path: In-Reply-To: <20150227002302.GF18360@dastard> Sender: fstests-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 02/27/2015 02:23 AM, Dave Chinner wrote: > On Thu, Feb 26, 2015 at 10:41:46AM +0200, Boaz Harrosh wrote: >> >> People systems have been using ramdisk with >> smaller-than-page-size blocks in their mkfs. >> >> The 4K sectors is only important if we will be >> using brd with a DAX filesystem. >> >> So only enable 4K sectors if DAX is configured > > 4k sectors are not a problem - we should be handling them fine and > because it makes the ramdisk look like a 512e drive, no applications > should fail, either. > > The main "unexpected" part about it was how much of xfstests didn't > handle 4k sectors in mkfs output properly. This isn't a problem with > the kernel change and so doesn't need fixing. > Glad to be of service ;-) Please tell me if there is anything I can help with > Cheers, > Dave. > Thanks Boaz