From: David Timber <dxdt@dev.snart.me>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: "Yuezhang.Mo@sony.com" <Yuezhang.Mo@sony.com>,
Sungjong Seo <sj1557.seo@samsung.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v1 4/4] exfat: more pedantic upcase table validity check
Date: Fri, 1 May 2026 21:20:01 +0900 [thread overview]
Message-ID: <54be304b-828a-4b79-8607-5004dbf78003@dev.snart.me> (raw)
In-Reply-To: <CAKYAXd8_9EpQw5w_0YNJ8FGZXmY7QsF6-6rRt5SjW==DSeYTUg@mail.gmail.com>
On 5/1/26 20:27, Namjae Jeon wrote:
> On Thu, Apr 30, 2026 at 6:24 PM David Timber <dxdt@dev.snart.me> wrote:
>> On 4/30/26 16:58, Yuezhang.Mo@sony.com wrote:
>>>> static int exfat_load_upcase_table(struct super_block *sb,
>>>> - sector_t sector, unsigned long long num_sectors,
>>>> - unsigned int utbl_checksum)
>>>> + unsigned long long tbl_size, sector_t sector,
>>>> + unsigned long long num_sectors, unsigned int utbl_checksum)
>>> After adding the parameter tbl_size, the parameter num_sectors is no
>>> longer needed.
>> Change the func signature? I'd like to hear Jeon's opinion on this.
> I agree. It is cleaner to remove num_sectors from the arguments and
> calculate it inside exfat_load_upcase_table() using tbl_size and
> sb->s_blocksize_bits.
Ack'd
prev parent reply other threads:[~2026-05-01 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 23:50 [PATCH v1 0/4] exfat: memory optimisations and stringent integrity checks for up-case table David Timber
2026-04-28 23:50 ` [PATCH v1 1/4] exfat: refactor nls.c (tables) David Timber
2026-04-30 7:53 ` Yuezhang.Mo
2026-04-30 9:22 ` David Timber
2026-05-03 8:03 ` David Timber
2026-04-28 23:50 ` [PATCH v1 2/4] exfat: use upcase_ptable and upcase_range_info to reduce memory footprint David Timber
2026-04-30 7:58 ` Yuezhang.Mo
2026-04-30 9:45 ` David Timber
2026-04-30 11:48 ` Yuezhang.Mo
2026-04-30 17:13 ` David Timber
2026-04-28 23:50 ` [PATCH v1 3/4] exfat: add default_upcase option (read-only) David Timber
2026-04-28 23:50 ` [PATCH v1 4/4] exfat: more pedantic upcase table validity check David Timber
2026-04-30 7:58 ` Yuezhang.Mo
2026-04-30 9:24 ` David Timber
2026-05-01 11:27 ` Namjae Jeon
2026-05-01 12:20 ` David Timber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54be304b-828a-4b79-8607-5004dbf78003@dev.snart.me \
--to=dxdt@dev.snart.me \
--cc=Yuezhang.Mo@sony.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox