From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1926AC433DB for ; Sat, 9 Jan 2021 16:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D79C5235FF for ; Sat, 9 Jan 2021 16:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbhAIQNZ (ORCPT ); Sat, 9 Jan 2021 11:13:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbhAIQNY (ORCPT ); Sat, 9 Jan 2021 11:13:24 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0CD9C061786; Sat, 9 Jan 2021 08:12:43 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id c5so11886923wrp.6; Sat, 09 Jan 2021 08:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BAeFMXpJ6VeYN5Oz6Bik3tS9JsMu6FyZikT7e4U/LvU=; b=hWuIBGVp9vNwk2d74SdCUn3URxvcSo2WcyCPnKKowbyzAj3WvVbks/JmSibtvM+TpH XCiUvub3mI6LCceeR1GhKcRLuJAOZnVS0N4yAHDf45u844e2NkXSymGXjaYyiombrxYj Z+sMZwBOO6nOD2yXv64Jj4yyah7B864CRZNoDfvQN9qFZCiTkQCiBRsr3pmZvWjJoA/F rBWY+mxeAzyHJoGra00M9YBR704e4KrCzrVZD3UGOp1vOT6p8OZpFRNsiHPWdYDR+WiB 97Gnw0UYyAiWVk6PS4MqT5bJOnwdgAohnCvMLmiOC6j8mtbRowFxlzTTGO152G2tZnO8 HTwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BAeFMXpJ6VeYN5Oz6Bik3tS9JsMu6FyZikT7e4U/LvU=; b=WXnBn5HCgQddyCJAQRCymk98qM0c/YbXOFRZuQurWQpQMxW40QkiCTTr8joaLnA0hN XeOt2VVsgreOeKXPNZ8RWzT3/HaF+yrgWsVN+0SWixajSe/pZbAe8svUD4sQ2wkNSzfb fJ/Oq7zp6sljx7HWRSu5XhyUQUiL0Khkn80FmvtVat3E9ze+37qRnBvt15m1xH8rJNgB EyMOoGZzDmXo/BI9Izj/4sYLHlQcM+uBT410b5EROVYzgAobShXZCbdXMZxPI+Idl9nl db4XYTEuo2WfgKivz6SIalSYWiTAZnXmXETnEh1e3a8sHQ0LPwaTyTXPJPHT78WR+tZv CZyw== X-Gm-Message-State: AOAM532H0MZiH7hJKvsRnaxHGrBekMr7oC3wK7xhmp2LUmIgPqhFkpYC HAGi4xrZevN600+CHlhxw+z0fTJrBxx0IA== X-Google-Smtp-Source: ABdhPJz3PG0FTrAEMDCji1mdU0wL8FigZbjluqgBy4mKGPyqDyC9lYZOQ+5XwcZjNi9KNSeKHl73Jg== X-Received: by 2002:adf:94e1:: with SMTP id 88mr8661271wrr.341.1610208760638; Sat, 09 Jan 2021 08:12:40 -0800 (PST) Received: from [192.168.8.114] ([185.69.144.125]) by smtp.gmail.com with ESMTPSA id c16sm18300069wrx.51.2021.01.09.08.12.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Jan 2021 08:12:39 -0800 (PST) Subject: Re: [PATCH] iov_iter: optimise iter type checking From: Pavel Begunkov To: linux-fsdevel@vger.kernel.org, Alexander Viro Cc: Jens Axboe , linux-kernel@vger.kernel.org References: <6e795064-fdbd-d354-4b01-a4f7409debf5@gmail.com> Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: <54cd4d1b-d7ec-a74c-8be0-e48780609d56@gmail.com> Date: Sat, 9 Jan 2021 16:09:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <6e795064-fdbd-d354-4b01-a4f7409debf5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 06/12/2020 16:01, Pavel Begunkov wrote: > On 21/11/2020 14:37, Pavel Begunkov wrote: >> The problem here is that iov_iter_is_*() helpers check types for >> equality, but all iterate_* helpers do bitwise ands. This confuses >> compilers, so even if some cases were handled separately with >> iov_iter_is_*(), corresponding ifs in iterate*() right after are not >> eliminated. >> >> E.g. iov_iter_npages() first handles discards, but iterate_all_kinds() >> still checks for discard iter type and generates unreachable code down >> the line. > > Ping. This one should be pretty simple Ping please. Any doubts about this patch? > >> >> text data bss dec hex filename >> before: 24409 805 0 25214 627e lib/iov_iter.o >> after: 23977 805 0 24782 60ce lib/iov_iter.o >> >> Reviewed-by: Jens Axboe >> Signed-off-by: Pavel Begunkov >> --- >> include/linux/uio.h | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/uio.h b/include/linux/uio.h >> index 72d88566694e..c5970b2d3307 100644 >> --- a/include/linux/uio.h >> +++ b/include/linux/uio.h >> @@ -57,27 +57,27 @@ static inline enum iter_type iov_iter_type(const struct iov_iter *i) >> >> static inline bool iter_is_iovec(const struct iov_iter *i) >> { >> - return iov_iter_type(i) == ITER_IOVEC; >> + return iov_iter_type(i) & ITER_IOVEC; >> } >> >> static inline bool iov_iter_is_kvec(const struct iov_iter *i) >> { >> - return iov_iter_type(i) == ITER_KVEC; >> + return iov_iter_type(i) & ITER_KVEC; >> } >> >> static inline bool iov_iter_is_bvec(const struct iov_iter *i) >> { >> - return iov_iter_type(i) == ITER_BVEC; >> + return iov_iter_type(i) & ITER_BVEC; >> } >> >> static inline bool iov_iter_is_pipe(const struct iov_iter *i) >> { >> - return iov_iter_type(i) == ITER_PIPE; >> + return iov_iter_type(i) & ITER_PIPE; >> } >> >> static inline bool iov_iter_is_discard(const struct iov_iter *i) >> { >> - return iov_iter_type(i) == ITER_DISCARD; >> + return iov_iter_type(i) & ITER_DISCARD; >> } >> >> static inline unsigned char iov_iter_rw(const struct iov_iter *i) >> > -- Pavel Begunkov