From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH v3] xfstest: generic/080 test that mmap-write updates c/mtime Date: Thu, 19 Mar 2015 13:49:24 +0200 Message-ID: <550AB7C4.8040302@gmail.com> References: <54F733BD.7060807@plexistor.com> <54F734C4.7080409@plexistor.com> <20150305001312.GA4251@dastard> <550A9C84.4090807@plexistor.com> <20150319104409.GO4810@dhcp-13-216.nay.redhat.com> <550AB720.3090009@plexistor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Matthew Wilcox , linux-fsdevel , fstests@vger.kernel.org To: Boaz Harrosh , Eryu Guan , Dave Chinner Return-path: In-Reply-To: <550AB720.3090009@plexistor.com> Sender: fstests-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 03/19/2015 01:46 PM, Boaz Harrosh wrote: > From: Dave Chinner > > when using mmap() for file i/o, writing to the file should update > it's c/mtime. Specifically if we first mmap-read from a page, then > memap-write to the same page. > > This test was failing for the initial submission of DAX because > pfn based mapping do not have an page_mkwrite called for them. > The new Kernel patches that introduce pfn_mkwrite fixes this test. > > Written by Dave Chinner but edited and tested by: > Omer Zilberberg > > Dave hands-up man, it looks like you edited this directly > in the email, but there was not even a single typo. > > Tested-by: Omer Zilberberg > Tested-by: Boaz Harrosh > Signed-off-by: Omer Zilberberg > Signed-off-by: Boaz Harrosh > Need-Reviewed-by: Eryu Guan Hi Eryu Thank you for your review. I have tried to incorporate your comments, I hope its what you meant. Thanks Boaz