From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: davem@davemloft.net, linux-aio@kvack.org,
herbert@gondor.apana.org.au, netdev@vger.kernel.org,
ying.xue@windriver.com, bcrl@kvack.org,
linux-fsdevel@vger.kernel.org, hch@lst.de,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/4] net: socket: add support for async operations
Date: Thu, 19 Mar 2015 10:43:16 -0700 [thread overview]
Message-ID: <550B0AB4.2060507@intel.com> (raw)
In-Reply-To: <20150319162024.GO29656@ZenIV.linux.org.uk>
On 03/19/2015 09:20 AM, Al Viro wrote:
> is completely pointless. Just have sock_read_iter() and sock_write_iter()
> check if your new methods are present and use those if those are.
>
Ok, that will work for me too.
> What's more, I'm not at all sure that you want to pass iocb that way -
> kernel-side msghdr isn't tied to userland one anymore, so we might as well
> stash a pointer to iocb into it. Voila - no new methods needed at all.
Good point, so what do you prefer - to add iocd to msghdr or to call the new
methods from sock_read_iter() and sock_write_iter()?
Either way is good for me.
next prev parent reply other threads:[~2015-03-19 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 16:15 [PATCH v2 net-next 0/4] Add support for async socket operations Tadeusz Struk
2015-03-16 16:15 ` [PATCH v2 net-next 1/4] net: socket: add support for async operations Tadeusz Struk
2015-03-19 16:20 ` Al Viro
2015-03-19 17:43 ` Tadeusz Struk [this message]
2015-03-19 18:13 ` Al Viro
2015-03-16 16:15 ` [PATCH v2 net-next 2/4] aio: prefer aio_op op over iter_op Tadeusz Struk
2015-03-19 16:22 ` Al Viro
2015-03-16 16:15 ` [PATCH v2 net-next 3/4] crypto: af_alg - Allow to link sgl Tadeusz Struk
2015-03-16 16:15 ` [PATCH v2 net-next 4/4] crypto: algif - change algif_skcipher to be asynchronous Tadeusz Struk
2015-03-18 20:59 ` [PATCH v2 net-next 0/4] Add support for async socket operations Tadeusz Struk
2015-03-18 23:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B0AB4.2060507@intel.com \
--to=tadeusz.struk@intel.com \
--cc=bcrl@kvack.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-aio@kvack.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).