JFS readdir() issues in stable 3.2

JFS readdir() issues in stable 3.2

[Richard Weinberger]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Hi!

Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2
(jfs: fix readdir cookie incompatibility with NFSv4) does not work as expected on 3.2.
Maybe on other stable kernels too.

UML stumbled over it:
https://bugzilla.kernel.org/show_bug.cgi?id=94741

If you run the attached readdir.c on a JFS on stable 3.2.51+ readdir() will not
increment the directory offset nor return NULL, hence the caller will loop forever.
It looks like if the current directory offset is > 0 and you run seekdir(telldir())
the next readdir() call will not increment it.

Dave, has your fix some unnamed dependencies which need backporting too?

Thanks,
//richard

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: readdir.c --]
[-- Type: text/x-csrc; name="readdir.c", Size: 462 bytes --]

#include <stdio.h>
#include <dirent.h>
#include <assert.h>

int main(int argc, char *argv[])
{
	DIR *dirp;
	struct dirent *dent;
	off_t dpos;

	if (argc < 2) {
		fprintf(stderr, "Usage: %s DIR\n", argv[0]);
		return 1;
	}

	dirp = opendir(argv[1]);
	assert(dirp);
	dpos = 0;

	for (;;) {
		seekdir(dirp, dpos);
		dent = readdir(dirp);
		if (!dent)
			break;
		assert(dpos != telldir(dirp));
		dpos = telldir(dirp);
	}

	return 0;
}

Re: JFS readdir() issues in stable 3.2

[Dave Kleikamp]

On 03/20/2015 06:33 PM, Richard Weinberger wrote:
> Hi!
> 
> Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2
> (jfs: fix readdir cookie incompatibility with NFSv4) does not work as expected on 3.2.
> Maybe on other stable kernels too.
> 
> UML stumbled over it:
> https://bugzilla.kernel.org/show_bug.cgi?id=94741
> 
> If you run the attached readdir.c on a JFS on stable 3.2.51+ readdir() will not
> increment the directory offset nor return NULL, hence the caller will loop forever.
> It looks like if the current directory offset is > 0 and you run seekdir(telldir())
> the next readdir() call will not increment it.

The backport failed to pass the proper position to filldir() for the .
and .. entries. I've attached a proposed patch to the above bug.

> 
> Dave, has your fix some unnamed dependencies which need backporting too?
> 
> Thanks,
> //richard

Thanks!
Shaggy

Re: JFS readdir() issues in stable 3.2

[Richard Weinberger]

Am 21.03.2015 um 22:58 schrieb Dave Kleikamp:
> On 03/20/2015 06:33 PM, Richard Weinberger wrote:
>> Hi!
>>
>> Mainline commit 44512449c0ab368889dd13ae0031fba74ee7e1d2
>> (jfs: fix readdir cookie incompatibility with NFSv4) does not work as expected on 3.2.
>> Maybe on other stable kernels too.
>>
>> UML stumbled over it:
>> https://bugzilla.kernel.org/show_bug.cgi?id=94741
>>
>> If you run the attached readdir.c on a JFS on stable 3.2.51+ readdir() will not
>> increment the directory offset nor return NULL, hence the caller will loop forever.
>> It looks like if the current directory offset is > 0 and you run seekdir(telldir())
>> the next readdir() call will not increment it.
> 
> The backport failed to pass the proper position to filldir() for the .
> and .. entries. I've attached a proposed patch to the above bug.

Thanks for sorting this out! :-)
//richard