From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 3/6] direct-io: add support for write stream IDs Date: Wed, 25 Mar 2015 08:26:16 -0600 Message-ID: <5512C588.2050805@kernel.dk> References: <1427210823-5283-1-git-send-email-axboe@fb.com> <1427210823-5283-4-git-send-email-axboe@fb.com> <20150325024328.GF31342@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ming.l@ssi.samsung.com To: Dave Chinner , Jens Axboe Return-path: In-Reply-To: <20150325024328.GF31342@dastard> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 03/24/2015 08:43 PM, Dave Chinner wrote: > On Tue, Mar 24, 2015 at 09:27:00AM -0600, Jens Axboe wrote: >> Get the streamid from the file, if any, and set it on the bio. >> >> Signed-off-by: Jens Axboe >> --- >> fs/direct-io.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/fs/direct-io.c b/fs/direct-io.c >> index e181b6b2e297..5d2750346451 100644 >> --- a/fs/direct-io.c >> +++ b/fs/direct-io.c >> @@ -77,6 +77,7 @@ struct dio_submit { >> int reap_counter; /* rate limit reaping */ >> sector_t final_block_in_request;/* doesn't change */ >> int boundary; /* prev block is at a boundary */ >> + int streamid; /* Write stream ID */ >> get_block_t *get_block; /* block mapping function */ >> dio_submit_t *submit_io; /* IO submition function */ >> >> @@ -372,6 +373,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, >> >> sdio->bio = bio; >> sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; >> + >> + bio_set_streamid(bio, sdio->streamid); >> } >> >> /* >> @@ -1205,6 +1208,7 @@ do_blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, >> sdio.blkbits = blkbits; >> sdio.blkfactor = i_blkbits - blkbits; >> sdio.block_in_file = offset >> blkbits; >> + sdio.streamid = iocb->ki_filp->f_streamid; > > If iocb->ki_filp->f_streamid is not set, then it should fall back to > whatever is set on the inode->i_streamid. Good point, agree. Will make that change. -- Jens Axboe