From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Matias_Bj=F8rling?= Subject: Re: [PATCH 1/5 v2] blk-mq: Add prep/unprep support Date: Fri, 17 Apr 2015 10:15:46 +0200 Message-ID: <5530C132.30107@bjorling.me> References: <1429101284-19490-1-git-send-email-m@bjorling.me> <1429101284-19490-2-git-send-email-m@bjorling.me> <20150417063439.GB389@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, javier@paletta.io To: Christoph Hellwig Return-path: Received: from mail-la0-f53.google.com ([209.85.215.53]:36053 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbbDQIPv (ORCPT ); Fri, 17 Apr 2015 04:15:51 -0400 Received: by lagv1 with SMTP id v1so74528682lag.3 for ; Fri, 17 Apr 2015 01:15:50 -0700 (PDT) In-Reply-To: <20150417063439.GB389@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 04/17/2015 08:34 AM, Christoph Hellwig wrote: > On Wed, Apr 15, 2015 at 02:34:40PM +0200, Matias Bj??rling wrote: >> Allow users to hook into prep/unprep functions just before an IO is >> dispatched to the device driver. This is necessary for request-based >> logic to take place at upper layers. > > I don't think any of this logic belongs into the block layer. All this > should be library functions called by the drivers. > Just the prep/unprep, or other pieces as well? I like that struct request_queue has a ref to struct nvm_dev, and the variables in request and bio to get to the struct is in the block layer. In the future, applications can have an API to get/put flash block directly. (using the blk_nvm_[get/put]_blk interface).