From: Richard Weinberger <richard@nod.at>
To: Fabian Frederick <fabf@skynet.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] affs: add default case in switch
Date: Sun, 03 May 2015 20:23:27 +0200 [thread overview]
Message-ID: <5546679F.5070000@nod.at> (raw)
In-Reply-To: <1190129389.190434.1430676950131.open-xchange@webmail.nmp.proximus.be>
Am 03.05.2015 um 20:15 schrieb Fabian Frederick:
>> If the code can be reached you need to take a proper action of not the
>> warning is bogus.
>
> As far as I understand, switch in affs_lookup() only updates inode number when
> it's a link so we can simply add default:break to silence gcc warning or replace
> by if().
Does the warning trigger with our default set of compiler warnings?
Not all gcc warnings are useful. :)
> affs_iget() switch on the other hand applies to any type of file.
> Maybe we could add default: BUG() to avoid working on bad inode ?
Or cancel the operation and return -EIO to userspace.
Thanks,
//richard
next prev parent reply other threads:[~2015-05-03 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 18:56 [PATCH 1/1 linux-next] affs: add default case in switch Fabian Frederick
2015-05-03 14:51 ` Richard Weinberger
2015-05-03 18:15 ` Fabian Frederick
2015-05-03 18:23 ` Richard Weinberger [this message]
2015-05-03 18:38 ` Fabian Frederick
2015-05-03 18:39 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5546679F.5070000@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).