From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 1/1 linux-next] affs: add default case in switch
Date: Sun, 03 May 2015 20:23:27 +0200
Message-ID: <5546679F.5070000@nod.at>
References: <1430592980-28856-1-git-send-email-fabf@skynet.be> <CAFLxGvyLsnus_OLX4x6bjtHEoHUESqdpfQpaXLVeKub-dL1s+Q@mail.gmail.com> <1190129389.190434.1430676950131.open-xchange@webmail.nmp.proximus.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Fabian Frederick <fabf@skynet.be>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750990AbbECSXa (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 3 May 2015 14:23:30 -0400
In-Reply-To: <1190129389.190434.1430676950131.open-xchange@webmail.nmp.proximus.be>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Am 03.05.2015 um 20:15 schrieb Fabian Frederick:
>> If the code can be reached you need to take a proper action of not the
>> warning is bogus.
> 
> As far as I understand, switch in affs_lookup() only updates inode number when
> it's a link so we can simply add default:break to silence gcc warning or replace
> by if().

Does the warning trigger with our default set of compiler warnings?
Not all gcc warnings are useful. :)

> affs_iget() switch on the other hand applies to any type of file.
> Maybe we could add default: BUG() to avoid working on bad inode ?

Or cancel the operation and return -EIO to userspace.

Thanks,
//richard