From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH] fs-eventpoll: Deletion of unnecessary checks before the function call "__pm_stay_awake" Date: Fri, 26 Jun 2015 19:42:13 +0200 Message-ID: <558D8EF5.9030701@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546B04E2.80000@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: Alexander Viro , linux-fsdevel@vger.kernel.org Return-path: Received: from mout.web.de ([212.227.17.12]:61147 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbbFZRmR (ORCPT ); Fri, 26 Jun 2015 13:42:17 -0400 In-Reply-To: <546B04E2.80000@users.sourceforge.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > From: Markus Elfring > Date: Tue, 18 Nov 2014 09:27:16 +0100 > > The __pm_stay_awake() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > fs/eventpoll.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 7bcfff9..eec2e85 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -555,8 +555,7 @@ static inline void ep_pm_stay_awake(struct epitem *epi) > { > struct wakeup_source *ws = ep_wakeup_source(epi); > > - if (ws) > - __pm_stay_awake(ws); > + __pm_stay_awake(ws); > } > > static inline bool ep_has_wakeup_source(struct epitem *epi) > @@ -571,8 +570,7 @@ static inline void ep_pm_stay_awake_rcu(struct epitem *epi) > > rcu_read_lock(); > ws = rcu_dereference(epi->ws); > - if (ws) > - __pm_stay_awake(ws); > + __pm_stay_awake(ws); > rcu_read_unlock(); > } > > How are the chances to integrate this update suggestion into another source code repository? Regards, Markus