From: Jens Axboe <axboe@fb.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Tejun Heo <tj@kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bdi: Remove "inline" keyword from exported I_BDEV() implementation
Date: Sat, 27 Jun 2015 11:44:21 -0600 [thread overview]
Message-ID: <558EE0F5.7040804@fb.com> (raw)
In-Reply-To: <1435319912-4335-1-git-send-email-geert@linux-m68k.org>
On 06/26/2015 05:58 AM, Geert Uytterhoeven wrote:
> With gcc 3.4.6/4.1.2/4.2.4 (not with 4.4.7/4.6.4/4.8.4):
>
> CC fs/block_dev.o
> include/linux/fs.h:804: warning: ‘I_BDEV’ declared inline after being called
> include/linux/fs.h:804: warning: previous declaration of ‘I_BDEV’ was here
>
> Commit a212b105b07d75b4 ("bdi: make inode_to_bdi() inline") added a
> caller of I_BDEV() in a header file, exposing the bogus "inline" on the
> exported implementation.
>
> Drop the "inline" keyword to fix this.
Added, thanks.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-06-27 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 11:58 [PATCH] bdi: Remove "inline" keyword from exported I_BDEV() implementation Geert Uytterhoeven
2015-06-27 17:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558EE0F5.7040804@fb.com \
--to=axboe@fb.com \
--cc=geert@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).