From: Sohny Thomas <sohnythomas@zoho.com>
To: Mikulas Patocka <mikulas@twibright.com>,
Linus Torvalds <torvalds@linux-foundation>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] hpfs: Remove unessary cast
Date: Mon, 29 Jun 2015 13:49:36 +0530 [thread overview]
Message-ID: <5590FF98.9050604@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1506281518020.29365@leontynka>
IMHO I think its better of being cast since you do have another pointer
inside the struct.
On 28-06-2015 18:48, Mikulas Patocka wrote:
> From: Firo Yang <firogm@gmail.com>
> Date: Thu, 23 Apr 2015 17:28:45 +0800
>
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
> ---
> fs/hpfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-4.1/fs/hpfs/super.c
> ===================================================================
> --- linux-4.1.orig/fs/hpfs/super.c 2015-06-22 20:17:54.000000000 +0200
> +++ linux-4.1/fs/hpfs/super.c 2015-06-22 21:27:59.000000000 +0200
> @@ -238,7 +238,7 @@ static struct kmem_cache * hpfs_inode_ca
> static struct inode *hpfs_alloc_inode(struct super_block *sb)
> {
> struct hpfs_inode_info *ei;
> - ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> + ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> if (!ei)
> return NULL;
> ei->vfs_inode.i_version = 1;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
prev parent reply other threads:[~2015-06-29 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 13:18 [PATCH] hpfs: Remove unessary cast Mikulas Patocka
2015-06-29 8:19 ` Sohny Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5590FF98.9050604@zoho.com \
--to=sohnythomas@zoho.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mikulas@twibright.com \
--cc=torvalds@linux-foundation \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).