From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sohny Thomas <sohnythomas@zoho.com>
Subject: Re: [PATCH] hpfs: Remove unessary cast
Date: Mon, 29 Jun 2015 13:49:36 +0530
Message-ID: <5590FF98.9050604@zoho.com>
References: <alpine.DEB.2.00.1506281518020.29365@leontynka>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Mikulas Patocka <mikulas@twibright.com>,
	Linus Torvalds <torvalds@linux-foundation>,
	linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from sender1.zohomail.com ([74.201.84.158]:21263 "EHLO
	sender153-mail.zoho.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752930AbbF2JC7 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 29 Jun 2015 05:02:59 -0400
In-Reply-To: <alpine.DEB.2.00.1506281518020.29365@leontynka>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

IMHO I think its better of being cast since you do have another pointer 
inside the struct.

On 28-06-2015 18:48, Mikulas Patocka wrote:
> From: Firo Yang <firogm@gmail.com>
> Date: Thu, 23 Apr 2015 17:28:45 +0800
>
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
> ---
>   fs/hpfs/super.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-4.1/fs/hpfs/super.c
> ===================================================================
> --- linux-4.1.orig/fs/hpfs/super.c	2015-06-22 20:17:54.000000000 +0200
> +++ linux-4.1/fs/hpfs/super.c	2015-06-22 21:27:59.000000000 +0200
> @@ -238,7 +238,7 @@ static struct kmem_cache * hpfs_inode_ca
>   static struct inode *hpfs_alloc_inode(struct super_block *sb)
>   {
>   	struct hpfs_inode_info *ei;
> -	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> +	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
>   	if (!ei)
>   		return NULL;
>   	ei->vfs_inode.i_version = 1;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus