From: Boaz Harrosh <boaz@plexistor.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
Boaz Harrosh <boaz@plexistor.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] mm: avoid setting up anonymous pages into file mapping
Date: Sun, 05 Jul 2015 19:38:13 +0300 [thread overview]
Message-ID: <55995D75.4020001@plexistor.com> (raw)
In-Reply-To: <20150705154441.GA4682@node.dhcp.inet.fi>
On 07/05/2015 06:44 PM, Kirill A. Shutemov wrote:
>> Again that could mean a theoretical regression for some in-tree driver,
>> do you know of any such driver?
>
> I did very little testing with the patch: boot kvm with Fedora and run
> trinity there for a while. More testing is required.
>
It seems more likely to be a bug in some obscure real HW driver, then
anything virtualized.
Let me run a quick search and see if I can see any obvious candidates
for this ...
<arch/x86/kernel/vsyscall_64.c>
static struct vm_operations_struct gate_vma_ops = {
.name = gate_vma_name,
};
Perhaps it was done for this one
</arch/x86/kernel/vsyscall_64.c>
<arch/x86/mm/mpx.c>
static struct vm_operations_struct mpx_vma_ops = {
.name = mpx_mapping_name,
};
Or this
</arch/x86/mm/mpx.c>
<more>
static const struct vm_operations_struct pci_mmap_ops = {
static const struct vm_operations_struct mmap_mem_ops = {
...
</more>
I was looking in-tree for any vm_operations_struct declaration without a .fault
member, there are these above and a slue of HW drivers that only have an .open
and .close so those might populate at open time and never actually ever fault.
Please have a quick look, I did not. I agree about the possible security badness.
Thanks
Boaz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-07-05 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 14:07 [PATCH] mm: avoid setting up anonymous pages into file mapping Kirill A. Shutemov
2015-07-05 15:15 ` Boaz Harrosh
2015-07-05 15:44 ` Kirill A. Shutemov
2015-07-05 16:38 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55995D75.4020001@plexistor.com \
--to=boaz@plexistor.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).