From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 11/25] ubifs: export read_block() from file.c Date: Tue, 21 Jul 2015 22:36:09 +0200 Message-ID: <55AEAD39.1070301@nod.at> References: <1437467876-22106-1-git-send-email-yangds.fnst@cn.fujitsu.com> <1437467876-22106-12-git-send-email-yangds.fnst@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org To: Dongsheng Yang , dedekind1@gmail.com, richard.weinberger@gmail.com, jack@suse.com Return-path: Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932503AbbGUUgN (ORCPT ); Tue, 21 Jul 2015 16:36:13 -0400 In-Reply-To: <1437467876-22106-12-git-send-email-yangds.fnst@cn.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Am 21.07.2015 um 10:37 schrieb Dongsheng Yang: > We want to use read_block to read quota file bypass the page cache. > So export it from file.c, then we can use it in somewhere else. > > Signed-off-by: Dongsheng Yang > --- > fs/ubifs/file.c | 2 +- > fs/ubifs/ubifs.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index 27de484..dc8bf0b 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -54,7 +54,7 @@ > #include > #include > > -static int read_block(struct inode *inode, void *addr, unsigned int block, > +int read_block(struct inode *inode, void *addr, unsigned int block, > struct ubifs_data_node *dn) > { > struct ubifs_info *c = inode->i_sb->s_fs_info; > diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h > index ae6723e..a6ad955 100644 > --- a/fs/ubifs/ubifs.h > +++ b/fs/ubifs/ubifs.h > @@ -1749,6 +1749,8 @@ const struct ubifs_lprops *ubifs_fast_find_frdi_idx(struct ubifs_info *c); > int ubifs_calc_dark(const struct ubifs_info *c, int spc); > > /* file.c */ > +int read_block(struct inode *inode, void *addr, unsigned int block, > + struct ubifs_data_node *dn); Please prefix the function name with ubifs_ to avoid namespace pollution. Thanks, //richard