From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Matias_Bj=F8rling?= Subject: Re: [PATCH v5 4/5] null_blk: LightNVM support Date: Thu, 23 Jul 2015 12:48:00 +0200 Message-ID: <55B0C660.8010509@lightnvm.io> References: <1437587464-7964-1-git-send-email-mb@lightnvm.io> <1437587464-7964-5-git-send-email-mb@lightnvm.io> <20150723095351.GB26420@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen.Bates@pmcs.com, keith.busch@intel.com To: Christoph Hellwig Return-path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:37029 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbbGWKsH (ORCPT ); Thu, 23 Jul 2015 06:48:07 -0400 Received: by wibud3 with SMTP id ud3so212685168wib.0 for ; Thu, 23 Jul 2015 03:48:04 -0700 (PDT) In-Reply-To: <20150723095351.GB26420@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 07/23/2015 11:53 AM, Christoph Hellwig wrote: > Any reason you're adding this to null_blk instead of having a separate > null_nvm driver? > Only reason was to not duplicate the I/O submission/completion flow. With the simple code at the moment, it is little to add. However, if someone decides to put backing store, simulation, etc. into it, then it should properly go into another module. Do you want me to move it into a new driver for this patchset?