From: Matias <mb@lightnvm.io>
To: Pavel Machek <pavel@ucw.cz>
Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Stephen.Bates@pmcs.com, keith.busch@intel.com,
"Javier González" <jg@lightnvm.io>
Subject: Re: [PATCH v6 5/5] nvme: LightNVM support
Date: Tue, 04 Aug 2015 14:00:09 +0200 [thread overview]
Message-ID: <55C0A949.1040406@lightnvm.io> (raw)
In-Reply-To: <20150802075753.GH3720@amd>
On 08/02/2015 09:57 AM, Pavel Machek wrote:
> Hi!
>
>> +struct nvme_nvm_hb_rw {
>> + __u8 opcode;
>> + __u8 flags;
>> + __u16 command_id;
>> + __le32 nsid;
>> + __u64 rsvd2;
>> + __le64 metadata;
>> + __le64 prp1;
>> + __le64 prp2;
>> + __le64 slba;
>> + __le16 length;
>> + __le16 control;
>> + __le32 dsmgmt;
>> + __le64 phys_addr;
>> +};
>
> You are not exporting this to userland, so you can get rid of "__"s.
>
> Pavel
>
>
Thanks. I will get them removed. It was a leftover for when it was in
the nvme uapi header.
next prev parent reply other threads:[~2015-08-04 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:17 [PATCH v6 0/5] Support for Open-Channel SSDs Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 1/5] lightnvm: " Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 2/5] lightnvm: Hybrid Open-Channel SSD RRPC target Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 3/5] lightnvm: Hybrid Open-Channel SSD block manager Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 4/5] null_nvm: Lightnvm test driver Matias Bjørling
2015-07-28 11:17 ` [PATCH v6 5/5] nvme: LightNVM support Matias Bjørling
2015-08-02 7:57 ` Pavel Machek
2015-08-04 12:00 ` Matias [this message]
2015-08-04 11:30 ` [PATCH v6 0/5] Support for Open-Channel SSDs Christoph Hellwig
2015-08-04 11:58 ` Matias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0A949.1040406@lightnvm.io \
--to=mb@lightnvm.io \
--cc=Stephen.Bates@pmcs.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=jg@lightnvm.io \
--cc=keith.busch@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).