From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v2 23/35] ubifs: set/clear MS_RDONLY properly in ubifs_remount
Date: Mon, 10 Aug 2015 10:46:40 +0800
Message-ID: <55C81090.1010802@cn.fujitsu.com>
References: <1438235311-23788-1-git-send-email-yangds.fnst@cn.fujitsu.com> <1438235311-23788-24-git-send-email-yangds.fnst@cn.fujitsu.com> <55C671F0.5050607@nod.at>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-15"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <linux-mtd@lists.infradead.org>, <linux-fsdevel@vger.kernel.org>
To: Richard Weinberger <richard@nod.at>, <viro@ZenIV.linux.org.uk>,
	<jack@suse.cz>, <dedekind1@gmail.com>,
	<richard.weinberger@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([59.151.112.132]:58845 "EHLO
	heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752305AbbHJCw2 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sun, 9 Aug 2015 22:52:28 -0400
In-Reply-To: <55C671F0.5050607@nod.at>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 08/09/2015 05:17 AM, Richard Weinberger wrote:
> Am 30.07.2015 um 07:48 schrieb Dongsheng Yang:
>> We need to set or clear MS_RDONLY in remounting.
>
> Care to explain why?
> Does the quota subsystem need that information?
> If so, where?

Ha, yes, you are right.

When we remount to rw from ro, we need to call dquot_resume.
And dquot_resume will call vfs_load_quota_inode() which
will check the MS_RDONLY. If it's ro mode, will return
an -EROFS.

And I know that we are using ->ro_mount in ubifs
to store the mounted mode. So we don't care about
the MS_RDONLY in ubifs. But why not to tell vfs we are in
ro or rw? Does it cause any problem?

Thanx
YAng

> Thanks,
> //richard
> .
>