linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
	linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Subodh Nijsure <snijsure@grid-net.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Brad Mouring <brad.mouring@ni.com>,
	Gratian Crisan <gratian.crisan@ni.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 1/2] ubifs: Remove dead xattr code
Date: Thu, 20 Aug 2015 08:45:37 +0200	[thread overview]
Message-ID: <55D57791.4000302@nod.at> (raw)
In-Reply-To: <55D54006.9030700@cn.fujitsu.com>

Am 20.08.2015 um 04:48 schrieb Dongsheng Yang:
> On 08/20/2015 04:35 AM, Richard Weinberger wrote:
>> This is a partial revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53
>> ("UBIFS: Add security.* XATTR support for the UBIFS").
> 
> Hi Richard,
>     What about a full reverting of this commit. In ubifs, we
> *can* support any namespace of xattr including user, trusted, security
> or other anyone prefixed by any words. But we have a check_namespace()
> in xattr.c to limit what we want to support. That said, if we want to
> "Add security.* XATTR support for the UBIFS", what we need to do is
> just extending the check_namespace() to allow security namespace pass.
> And yes, check_namespace() have been supporting security namespace.

You're right. I thought/hoped we can re-use some parts of it.
Se let's do a full revert. I'll send a v2 patch in a jiffy.

> So, IMHO, we do not depend on the generic mechanism at all, and we can
> fully revert this commit.
> 
> But strange to me, why we picked this commit for ubifs? Artem, is there
> something I am missing?

TBH, I fear nobody noticed. :(

Thanks,
//richard

  parent reply	other threads:[~2015-08-20  6:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 20:35 [PATCH 1/2] ubifs: Remove dead xattr code Richard Weinberger
2015-08-19 20:35 ` [PATCH 2/2] ubifs: Allow O_DIRECT Richard Weinberger
2015-08-20  3:00   ` Dongsheng Yang
2015-08-20  6:42     ` Richard Weinberger
2015-08-20  7:14       ` Dongsheng Yang
2015-08-20 11:31     ` Artem Bityutskiy
2015-08-20 11:40       ` Richard Weinberger
2015-08-20 12:34         ` Artem Bityutskiy
2015-08-24  7:18           ` Artem Bityutskiy
2015-08-24  7:17             ` Dongsheng Yang
2015-08-24  7:20               ` Dongsheng Yang
2015-08-24  8:06               ` Christoph Hellwig
2015-08-20 20:49         ` Brian Norris
2015-08-24  7:13           ` Artem Bityutskiy
2015-08-24  7:53             ` Christoph Hellwig
2015-08-24  8:02               ` Artem Bityutskiy
2015-08-24  8:03                 ` Christoph Hellwig
2015-08-24  8:00                   ` Dongsheng Yang
2015-08-24  9:34                   ` Artem Bityutskiy
2015-08-24  9:35                     ` Richard Weinberger
2015-08-24 16:18             ` Brian Norris
2015-08-24 17:19               ` Jeff Moyer
2015-08-24 23:46                 ` Dave Chinner
2015-08-25  1:28                   ` Chris Mason
2015-08-25 15:48                     ` Artem Bityutskiy
2015-08-25 14:00                   ` Jeff Moyer
2015-08-25 14:13                     ` Chris Mason
2015-08-25 14:18                       ` Jeff Moyer
2015-08-20 11:29   ` Artem Bityutskiy
2015-08-20  2:48 ` [PATCH 1/2] ubifs: Remove dead xattr code Dongsheng Yang
2015-08-20  6:42   ` Artem Bityutskiy
2015-08-20  6:45   ` Richard Weinberger [this message]
2015-08-26 14:15   ` Josh Cartwright
2015-08-27  1:00     ` Dongsheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D57791.4000302@nod.at \
    --to=richard@nod.at \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=brad.mouring@ni.com \
    --cc=dedekind1@gmail.com \
    --cc=gratian.crisan@ni.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    --cc=snijsure@grid-net.com \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).