From: Matias Bjorling <m@bjorling.me>
To: "Ross Zwisler" <ross.zwisler@linux.intel.com>,
axboe@fb.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, "Matias Bjørling" <mb@lightnvm.io>
Subject: Re: [PATCH] null_blk: fix memory leak on cleanup
Date: Thu, 3 Sep 2015 07:48:34 +0200 [thread overview]
Message-ID: <55E7DF32.1080805@bjorling.me> (raw)
In-Reply-To: <20150902183928.GA32255@linux.intel.com>
Den 02-09-2015 kl. 20:39 skrev Ross Zwisler:
> On Mon, Aug 31, 2015 at 02:17:18PM +0200, Matias Bjørling wrote:
>> From: Matias Bjørling <mb@lightnvm.io>
>>
>> Driver was not freeing the memory allocated for internal nullb queues.
>> This patch frees the memory during driver unload.
>
> You may want to consider devm_* style allocations instead. These are freed
> automatically on driver unload, simplifying your error paths and your unload
> logic as well as preventing leaks.
>
> See this patch for an example:
>
> https://lkml.org/lkml/2015/8/10/992
>
Thanks for looking through the patches. I'll look into it.
next prev parent reply other threads:[~2015-09-03 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 12:17 [PATCH] null_blk: fix memory leak on cleanup Matias Bjørling
2015-09-02 18:39 ` Ross Zwisler
2015-09-03 5:48 ` Matias Bjorling [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 12:01 Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7DF32.1080805@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).