linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Cc: "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>,
	Trond Myklebust
	<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>,
	kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: [PATCH 4/6 v10] fs: New helper legitimize_mntget() for getting a legitimize mnt
Date: Mon, 7 Sep 2015 22:04:54 +0800	[thread overview]
Message-ID: <55ED9986.3040203@gmail.com> (raw)
In-Reply-To: <55ED9899.9010401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

New helper legitimize_mntget for getting a mnt without setting
MNT_SYNC_UMOUNT | MNT_UMOUNT | MNT_DOOMED, otherwise return NULL.

v9, Update using read_seqbegin_or_lock instead read_seqlock_excl
v10, fix bad logical of using seqlock

Signed-off-by: Kinglong Mee <kinglongmee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 fs/namespace.c        | 38 ++++++++++++++++++++++++++++++++++++++
 include/linux/mount.h |  1 +
 2 files changed, 39 insertions(+)

diff --git a/fs/namespace.c b/fs/namespace.c
index 0570729..6377672 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1153,6 +1153,44 @@ struct vfsmount *mntget(struct vfsmount *mnt)
 }
 EXPORT_SYMBOL(mntget);
 
+struct vfsmount *legitimize_mntget(struct vfsmount *vfsmnt)
+{
+	struct mount *mnt;
+	unsigned seq = 0;
+
+	if (vfsmnt == NULL)
+		return NULL;
+
+	rcu_read_lock();
+retry:
+	read_seqbegin_or_lock(&mount_lock, &seq);
+
+	if (vfsmnt->mnt_flags & (MNT_SYNC_UMOUNT | MNT_UMOUNT | MNT_DOOMED))
+		vfsmnt = NULL;
+	else {
+		mnt = real_mount(vfsmnt);
+		mnt_add_count(mnt, 1);
+		if (need_seqretry(&mount_lock, seq)) {
+			/* lost the race, need to try again */
+			if (vfsmnt->mnt_flags & MNT_SYNC_UMOUNT) {
+				/* no point trying... */
+				mnt_add_count(mnt, -1);
+				vfsmnt = NULL;
+			} else {
+				mntput(vfsmnt);
+				seq = 1;
+				goto retry;
+			}
+		}
+	}
+
+	done_seqretry(&mount_lock, seq);
+	rcu_read_unlock();
+
+	return vfsmnt;
+}
+EXPORT_SYMBOL(legitimize_mntget);
+
 struct vfsmount *mnt_clone_internal(struct path *path)
 {
 	struct mount *p;
diff --git a/include/linux/mount.h b/include/linux/mount.h
index f822c3c..8ae9dc0 100644
--- a/include/linux/mount.h
+++ b/include/linux/mount.h
@@ -79,6 +79,7 @@ extern void mnt_drop_write(struct vfsmount *mnt);
 extern void mnt_drop_write_file(struct file *file);
 extern void mntput(struct vfsmount *mnt);
 extern struct vfsmount *mntget(struct vfsmount *mnt);
+extern struct vfsmount *legitimize_mntget(struct vfsmount *vfsmnt);
 extern struct vfsmount *mnt_clone_internal(struct path *path);
 extern int __mnt_is_readonly(struct vfsmount *mnt);
 
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-07 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 14:00 [PATCH 0/6 v10] NFSD: Pin to vfsmount for nfsd exports cache Kinglong Mee
2015-09-07 14:04 ` [PATCH 3/6 v10] path: New helpers path_get_pin/path_put_unpin for path,pin Kinglong Mee
     [not found] ` <55ED9899.9010401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-07 14:02   ` [PATCH 1/6 v10] fs-pin: allow pin_remove() to be called other than from->kill() Kinglong Mee
2015-09-07 14:03   ` [PATCH 2/6 v10] fs_pin: Export functions for specific filesystem Kinglong Mee
2015-09-07 14:04   ` Kinglong Mee [this message]
2015-09-07 14:05   ` [PATCH 5/6 v10] sunrpc: New helper cache_delete_entry for deleting cache_head directly Kinglong Mee
2015-09-07 14:06 ` [PATCH 6/6 v10] nfsd: Allows user un-mounting filesystem where nfsd exports base on Kinglong Mee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ED9986.3040203@gmail.com \
    --to=kinglongmee-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=neilb-l3A5Bk7waGM@public.gmane.org \
    --cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).