From mboxrd@z Thu Jan 1 00:00:00 1970 From: Palmer Dabbelt Subject: Re: [PATCH 11/13] Always define MAX_RAW_MINORS as 65535 in userspace Date: Wed, 16 Sep 2015 20:08:26 -0700 (PDT) Message-ID: <55fa2eaa.ca39440a.feaa1.36f5@mx.google.com> References: <55F882C7.4080304@zytor.com> Cc: arnd@arndb.de To: hpa@zytor.com Return-path: CC: dhowells@redhat.com CC: viro@zeniv.linux.org.uk CC: ast@plumgrid.com CC: aishchuk@linux.vnet.ibm.com CC: aarcange@redhat.com CC: akpm@linux-foundation.org CC: luto@kernel.org CC: acme@kernel.org CC: bhe@redhat.com CC: 3chas3@gmail.com CC: chris@zankel.net CC: dave@sr71.net CC: dyoung@redhat.com CC: drysdale@google.com CC: davem@davemloft.net CC: ebiederm@xmission.com CC: geoff@infradead.org CC: gregkh@linuxfoundation.org CC: mingo@kernel.org CC: iulia.manda21@gmail.com CC: plagnioj@jcrosoft.com CC: jikos@kernel.org CC: josh@joshtriplett.org CC: kexec@lists.infradead.org CC: linux-api@vger.kernel.org CC: linux-arch@vger.kernel.org CC: linux-fsdevel@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: linux-xtensa@linux-xtensa.org CC: mathieu.desnoyers@efficios.com CC: jcmvbkbc@gmail.com CC: paulmck@linux.vnet.ibm.com CC: a.p.zijlstra@chello.nl CC: tglx@linutronix.de CC: tomi.valkeinen@ti.com CC: vgoyal@redhat.com CC: x86@kernel.org In-Reply-To: <55F882C7.4080304@zytor.com> Sender: linux-arch-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 15 Sep 2015 13:42:47 PDT (-0700), hpa@zytor.com wrote: > On 09/14/2015 03:50 PM, Palmer Dabbelt wrote: >> While I don't think this was ever meant to be exposed to userspace, if >> anyone is using it then this will at least provide a correct (if >> unlikely) definition. >> >> MAX_RAW_MINORS used to be used in the kernel, where it's been replaced >> with CONFIG_MAX_RAW_MINORS. >> >> Note that there's a checkpatch.pl warning about a split config string >> here, but I've left that alone. > > From a UAPI perspective I would think the right value would be 2^20. Wow, I'm super surprised. For some reason I thought major/minor numbers were 16 bits, but according to glibc I just have no idea what I'm doing :). Thanks for catching this!