From mboxrd@z Thu Jan  1 00:00:00 1970
From: Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c
Date: Thu, 17 Sep 2015 13:53:16 -0700 (PDT)
Message-ID: <55fb283c.f039440a.427ff.fffff187@mx.google.com>
References: <15268.1442483832@warthog.procyon.org.uk>
Cc: dhowells@redhat.com
To: dhowells@redhat.com
Return-path: <linux-arch-owner@vger.kernel.org>
CC: arnd@arndb.de
CC: viro@zeniv.linux.org.uk
CC: ast@plumgrid.com
CC: aishchuk@linux.vnet.ibm.com
CC: aarcange@redhat.com
CC: akpm@linux-foundation.org
CC: luto@kernel.org
CC: acme@kernel.org
CC: bhe@redhat.com
CC: 3chas3@gmail.com
CC: chris@zankel.net
CC: dave@sr71.net
CC: dyoung@redhat.com
CC: drysdale@google.com
CC: davem@davemloft.net
CC: ebiederm@xmission.com
CC: geoff@infradead.org
CC: gregkh@linuxfoundation.org
CC: hpa@zytor.com
CC: mingo@kernel.org
CC: iulia.manda21@gmail.com
CC: plagnioj@jcrosoft.com
CC: jikos@kernel.org
CC: josh@joshtriplett.org
CC: kexec@lists.infradead.org
CC: linux-api@vger.kernel.org
CC: linux-arch@vger.kernel.org
CC: linux-fsdevel@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-xtensa@linux-xtensa.org
CC: mathieu.desnoyers@efficios.com
CC: jcmvbkbc@gmail.com
CC: paulmck@linux.vnet.ibm.com
CC: a.p.zijlstra@chello.nl
CC: tglx@linutronix.de
CC: tomi.valkeinen@ti.com
CC: vgoyal@redhat.com
CC: x86@kernel.org
In-Reply-To: <15268.1442483832@warthog.procyon.org.uk>
Sender: linux-arch-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Thu, 17 Sep 2015 02:57:12 PDT (-0700), dhowells@redhat.com wrote:
> Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
>> +#ifdef CONFIG_COMPAT
>> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
>> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
>> +#endif
>
> I wonder if it would hurt to ditch the conditionals entirely.  It only eats
> cpp namespace, not C namespace so it won't affect the output if it is not used
> because the code that uses it is compiled out.

Makes sense to me.