linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
	linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	dedekind1@gmail.com
Subject: Re: [PATCH] UBIFS: Add freeze support in ubifs
Date: Sun, 27 Sep 2015 10:06:31 +0200	[thread overview]
Message-ID: <5607A387.9050703@nod.at> (raw)
In-Reply-To: <1443321561-20581-1-git-send-email-yangds.fnst@cn.fujitsu.com>

Yang,

Am 27.09.2015 um 04:39 schrieb Dongsheng Yang:
> We need to do nothing in ubifs, as all is already done in vfs.

Please more details. :-)
The current changelog reads like every filesystem should implement
it as nop. Which is obviously not the case.

fs/super.c checks whether ->freeze_fs() is implemented, so
a nop-implementation does not make sense here.

I bet you hit this in fs/ioctl.c:
        /* If filesystem doesn't support freeze feature, return. */
        if (sb->s_op->freeze_fs == NULL && sb->s_op->freeze_super == NULL)
                return -EOPNOTSUPP;

Correct?

And the most important detail is missing, why is UBIFS allowed
to have a nop-implementation?

Thanks,
//richard

  reply	other threads:[~2015-09-27  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27  2:39 [PATCH] UBIFS: Add freeze support in ubifs Dongsheng Yang
2015-09-27  8:06 ` Richard Weinberger [this message]
2015-09-28  3:10   ` Dongsheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5607A387.9050703@nod.at \
    --to=richard@nod.at \
    --cc=dedekind1@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).